chrome/browser/ui/webui/print_preview/print_preview_handler.cc - Issue 568633002: Extracted MetafilePlayer interface from printing::MetafilePlayer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/print_preview/print_preview_handler.cc

Issue 568633002: Extracted MetafilePlayer interface from printing::MetafilePlayer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@no_expose

Patch Set: Thu Sep 11 16:10:13 PDT 2014 Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/libgtk2ui/print_dialog_gtk2.cc ('k') | chrome/renderer/printing/print_web_view_helper_linux.cc » ('j') | chrome/service/service_utility_process_host.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/print_preview/print_preview_handler.cc

diff --git a/chrome/browser/ui/webui/print_preview/print_preview_handler.cc b/chrome/browser/ui/webui/print_preview/print_preview_handler.cc

index 06894a481c3d33cff4af311905f1c117a9fa7a35..2b3ac6b1989b385a55ed30d08521a1d03447f22e 100644

--- a/chrome/browser/ui/webui/print_preview/print_preview_handler.cc

+++ b/chrome/browser/ui/webui/print_preview/print_preview_handler.cc

@@ -246,7 +246,9 @@ void PrintToPdfCallback(const scoped_refptr<base::RefCountedBytes>& data,

DCHECK_CURRENTLY_ON(BrowserThread::FILE);

printing::PdfMetafileSkia metafile;

metafile.InitFromData(static_cast<const void*>(data->front()), data->size());

- metafile.SaveTo(path);

+ base::File file(path,

+ base::File::FLAG_CREATE_ALWAYS || base::File::FLAG_WRITE);

+ metafile.SaveTo(&file);

if (!pdf_file_saved_closure.is_null())

pdf_file_saved_closure.Run();

}