chrome/browser/printing/print_view_manager_base.cc - Issue 568633002: Extracted MetafilePlayer interface from printing::MetafilePlayer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/print_view_manager_base.cc

Issue 568633002: Extracted MetafilePlayer interface from printing::MetafilePlayer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@no_expose

Patch Set: Thu Sep 11 16:10:13 PDT 2014 Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/printing/print_view_manager_base.h ('k') | chrome/browser/ui/libgtk2ui/print_dialog_gtk2.h » ('j') | chrome/service/service_utility_process_host.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/printing/print_view_manager_base.cc

diff --git a/chrome/browser/printing/print_view_manager_base.cc b/chrome/browser/printing/print_view_manager_base.cc

index 45f34df0e87259733ad3756497a94855f3e5a3e5..082dd7e4beec0ee81779d5e0a5139aed446f33c6 100644

--- a/chrome/browser/printing/print_view_manager_base.cc

+++ b/chrome/browser/printing/print_view_manager_base.cc

@@ -130,7 +130,7 @@ void PrintViewManagerBase::OnDidGetDocumentCookie(int cookie) {

void PrintViewManagerBase::OnPdfToEmfConverted(

const PrintHostMsg_DidPrintPage_Params& params,

double scale_factor,

- ScopedVector<Metafile>* emf_files) {

+ ScopedVector<MetafilePlayer>* emf_files) {

if (!print_job_.get())

return;

@@ -148,7 +148,7 @@ void PrintViewManagerBase::OnPdfToEmfConverted(

for (size_t i = 0; i < emf_files->size(); ++i) {

// Update the rendered document. It will send notifications to the listener.

document->SetPage(i,

- (*emf_files)[i],

+ make_scoped_ptr((*emf_files)[i]),

scale_factor,

params.page_size,

params.content_area);