Extracted MetafilePlayer interface from printing::MetafilePlayer.

Extracted MetafilePlayer interface from printing::MetafilePlayer.

Removed some unused code.
Updated interfaces from plain pointers to scoped_ptr<>
SaveTo(base::FilePath) replaced with SaveTo(base::File).

BUG=408184
TBR=sgurun@chromium.org

Committed: https://crrev.com/5d1290581ae0d39d5c640c1f95ba298946515dbe
Cr-Commit-Position: refs/heads/master@{#294556}

[Vitaly Buka (NO REVIEWS), 2014-09-11 23:12:56]

vitalybuka@chromium.org changed reviewers:
+ thestig@chromium.org

[Lei Zhang, 2014-09-11 23:31:10]

lgtm, but please fix the GN build.

https://codereview.chromium.org/568633002/diff/40001/chrome/service/service_u...
File chrome/service/service_utility_process_host.h (right):

https://codereview.chromium.org/568633002/diff/40001/chrome/service/service_u...
chrome/service/service_utility_process_host.h:143: const
std::vector<printing::PageRange>& page_ranges,
nit: 4 space indent

https://codereview.chromium.org/568633002/diff/40001/printing/metafile.h
File printing/metafile.h (right):

https://codereview.chromium.org/568633002/diff/40001/printing/metafile.h#newc...
printing/metafile.h:69: MetafilePlayer() {}
nit: Move impl to .cc file

http://www.chromium.org/developers/coding-style/cpp-dos-and-donts#TOC-Stop-in....

https://codereview.chromium.org/568633002/diff/40001/printing/pdf_metafile_sk...
File printing/pdf_metafile_skia.cc (right):

https://codereview.chromium.org/568633002/diff/40001/printing/pdf_metafile_sk...
printing/pdf_metafile_skia.cc:221: scoped_ptr<PdfMetafileSkia> metafile(new
PdfMetafileSkia);
nit: Just put an empty scoper at the top and always return metafile.Pass()?

https://codereview.chromium.org/568633002/diff/40001/printing/printing.gyp
File printing/printing.gyp (right):

https://codereview.chromium.org/568633002/diff/40001/printing/printing.gyp#ne...
printing/printing.gyp:47: 'metafile.cc',
Also change printing/BUILD.gn.

[Vitaly Buka (NO REVIEWS), 2014-09-12 01:43:26]

Patchset #4 (id:60001) has been deleted

[Vitaly Buka (NO REVIEWS), 2014-09-12 01:52:21]

Patchset #4 (id:80001) has been deleted

[Vitaly Buka (NO REVIEWS), 2014-09-12 01:54:00]

https://codereview.chromium.org/568633002/diff/40001/chrome/service/service_u...
File chrome/service/service_utility_process_host.h (right):

https://codereview.chromium.org/568633002/diff/40001/chrome/service/service_u...
chrome/service/service_utility_process_host.h:143: const
std::vector<printing::PageRange>& page_ranges,
On 2014/09/11 23:31:10, Lei Zhang wrote:
> nit: 4 space indent

Done.

https://codereview.chromium.org/568633002/diff/40001/printing/metafile.h
File printing/metafile.h (right):

https://codereview.chromium.org/568633002/diff/40001/printing/metafile.h#newc...
printing/metafile.h:69: MetafilePlayer() {}
On 2014/09/11 23:31:10, Lei Zhang wrote:
> nit: Move impl to .cc file
> 
>
http://www.chromium.org/developers/coding-style/cpp-dos-and-donts#TOC-Stop-in....

Done.

https://codereview.chromium.org/568633002/diff/40001/printing/pdf_metafile_sk...
File printing/pdf_metafile_skia.cc (right):

https://codereview.chromium.org/568633002/diff/40001/printing/pdf_metafile_sk...
printing/pdf_metafile_skia.cc:221: scoped_ptr<PdfMetafileSkia> metafile(new
PdfMetafileSkia);
On 2014/09/11 23:31:10, Lei Zhang wrote:
> nit: Just put an empty scoper at the top and always return metafile.Pass()?

Done.

https://codereview.chromium.org/568633002/diff/40001/printing/printing.gyp
File printing/printing.gyp (right):

https://codereview.chromium.org/568633002/diff/40001/printing/printing.gyp#ne...
printing/printing.gyp:47: 'metafile.cc',
On 2014/09/11 23:31:10, Lei Zhang wrote:
> Also change printing/BUILD.gn.

Done.

[Vitaly Buka (NO REVIEWS), 2014-09-12 02:00:57]

The CQ bit was checked by vitalybuka@chromium.org

[commit-bot: I haz the power, 2014-09-12 02:03:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/568633002/120001

[Vitaly Buka (NO REVIEWS), 2014-09-12 02:11:23]

The CQ bit was checked by vitalybuka@chromium.org

[commit-bot: I haz the power, 2014-09-12 02:14:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/568633002/140001

[commit-bot: I haz the power, 2014-09-12 02:35:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-12 02:35:15]

Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)

[Vitaly Buka (NO REVIEWS), 2014-09-12 05:56:57]

The CQ bit was checked by vitalybuka@chromium.org

[commit-bot: I haz the power, 2014-09-12 05:57:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/568633002/160001

[commit-bot: I haz the power, 2014-09-12 06:11:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-12 06:11:48]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Vitaly Buka (NO REVIEWS), 2014-09-12 06:26:55]

The CQ bit was checked by vitalybuka@chromium.org

[commit-bot: I haz the power, 2014-09-12 06:28:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/568633002/160001

[commit-bot: I haz the power, 2014-09-12 09:22:02]

Committed patchset #7 (id:160001) as d143df772d66add9ce77dc38accd65afdcd5211d

[commit-bot: I haz the power, 2014-09-12 09:29:15]

Patchset 7 (id:??) landed as
https://crrev.com/5d1290581ae0d39d5c640c1f95ba298946515dbe
Cr-Commit-Position: refs/heads/master@{#294556}