Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(761)

Issue 568613002: gn: use bundled binutils via -B (Closed)

Created:
6 years, 3 months ago by scottmg
Modified:
6 years, 3 months ago
Reviewers:
brettw
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@gn-various-matching
Project:
chromium
Visibility:
Public.

Description

gn: use bundled binutils via -B - Use bundled binutils by adding to cflags -B - Enables dwarf-fission based on bundling (maybe correct?) - Makes differ normalize -B paths so they can be compared between gyp/gn. R=brettw@chromium.org BUG=335824 Committed: https://crrev.com/416440522fa2e5034c76a2adbe069bc7c6faaf55 Cr-Commit-Position: refs/heads/master@{#295185}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : match condition in gyp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -5 lines) Patch
M build/config/compiler/BUILD.gn View 1 2 3 chunks +13 lines, -5 lines 0 comments Download
M tools/gn/bin/gyp_flag_compare.py View 1 2 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
scottmg
6 years, 3 months ago (2014-09-11 23:06:44 UTC) #1
scottmg
i think this makes sense now
6 years, 3 months ago (2014-09-16 22:56:39 UTC) #2
brettw
lgtm
6 years, 3 months ago (2014-09-16 23:13:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/568613002/40001
6 years, 3 months ago (2014-09-16 23:14:58 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 2a01fb867ac475377220e660309d78ea922472aa
6 years, 3 months ago (2014-09-17 00:19:41 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-17 00:20:25 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/416440522fa2e5034c76a2adbe069bc7c6faaf55
Cr-Commit-Position: refs/heads/master@{#295185}

Powered by Google App Engine
This is Rietveld 408576698