Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 568593002: Include svn revision range in Blink roll descriptions. (Closed)

Created:
6 years, 3 months ago by skobes
Modified:
6 years, 3 months ago
Reviewers:
CC:
chromium-reviews, pgervais+watch_chromium.org, kjellander-cc_chromium.org, cmp-cc_chromium.org, stip+watch_chromium.org
Project:
tools
Visibility:
Public.

Description

Include svn revision range in Blink roll descriptions. Prior to http://crrev.com/495493003, Blink rolls had the Blink svn revision range in their descriptions, which made it easy to determine which roll contained a given revision number by scanning the log of src/DEPS. To do this with git hashes is much more difficult since they are not sequential and cannot be compared at a glance. This change adds the svn range even when git_mode is True. The resulting descriptions look like: Blink roll hash1:hash2 (svn 1234:1235) TBR=szager@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=291939

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -37 lines) Patch
M scripts/tools/blink_roller/auto_roll.py View 6 chunks +54 lines, -21 lines 0 comments Download
M scripts/tools/blink_roller/auto_roll_test.py View 8 chunks +34 lines, -16 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
skobes
This change was reviewed in https://codereview.chromium.org/559243002. Trying to commit in a new Rietveld issue.
6 years, 3 months ago (2014-09-11 22:14:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/568593002/1
6 years, 3 months ago (2014-09-11 22:16:00 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 22:17:36 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 291939

Powered by Google App Engine
This is Rietveld 408576698