Introduce WebRequestEventRouterDelegate.

chrome/browser/extensions/api/chrome_extensions_api_client.cc

Index: chrome/browser/extensions/api/chrome_extensions_api_client.cc
diff --git a/chrome/browser/extensions/api/chrome_extensions_api_client.cc b/chrome/browser/extensions/api/chrome_extensions_api_client.cc
index 4132234fdc669cf0fc2796dc779170a708966bc5..295be0c1dcfaf575fe717297f5d24e701baa40b8 100644
--- a/chrome/browser/extensions/api/chrome_extensions_api_client.cc
+++ b/chrome/browser/extensions/api/chrome_extensions_api_client.cc
@@ -7,6 +7,7 @@
 #include "base/files/file_path.h"
 #include "chrome/browser/extensions/api/declarative/rules_registry_service.h"
 #include "chrome/browser/extensions/api/storage/sync_value_store_cache.h"
+#include "chrome/browser/extensions/api/web_request/chrome_extension_web_request_event_router_delegate.h"
 #include "chrome/browser/guest_view/app_view/chrome_app_view_guest_delegate.h"
 #include "chrome/browser/guest_view/extension_options/chrome_extension_options_guest_delegate.h"
 #include "chrome/browser/guest_view/mime_handler_view/chrome_mime_handler_view_guest_delegate.h"
@@ -81,4 +82,9 @@ scoped_refptr<RulesRegistry> ChromeExtensionsAPIClient::GetRulesRegistry(
       GetRulesRegistry(webview_key, event_name);
 }
 
+WebRequestEventRouterDelegate* ChromeExtensionsAPIClient::

[Ken Rockot(use gerrit already), 2014/09/19 20:52:27]

nit: Style guide insists that in cases like this, the return type gets its own
line and the method name is not indented. So:

WebRequestEventRouterDelegate*
ChromeExtensionsAPIClient::CreateWebRequestEventRouterDelegate() const {

Would be the correct format.

If you run 'git cl format' before upload, it will probably do this kind of stuff
for you.

[Xi Han, 2014/09/19 22:05:55]

Thanks Ken, I looked for style for this case but didn't find it. I try to avoid
using git cl format, since it adds lots of unnecessary changes for the files
being touched:(.

Updated.


On 2014/09/19 20:52:27, Ken Rockot wrote:

[Ken Rockot(use gerrit already), 2014/09/19 23:08:33]

OK, that's fair. In general we would prefer to see all code adhere to the style
guides set by the formatting tool so there's no ambiguity. It does add extra
noise for code reviews, but IMO it's fine. Please don't hesitate to apply
auto-formatting when sending code reviews my way, I'm used to the noise. :)

[Xi Han, 2014/09/22 14:34:15]

Glad to know:)


On 2014/09/19 23:08:33, Ken Rockot wrote:

+    CreateWebRequestEventRouterDelegate() const {
+  return new ChromeExtensionWebRequestEventRouterDelegate();
+}
+
 }  // namespace extensions