Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 568523002: Remove deprecated IsolateHolder constructor (Closed)

Created:
6 years, 3 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 3 months ago
Reviewers:
marja
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove deprecated IsolateHolder constructor BUG=none R=marja@chromium.org Committed: https://crrev.com/b6d92a8f937cbabd2d97c034f873ecbb6e1f26fb Cr-Commit-Position: refs/heads/master@{#294568}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -46 lines) Patch
M gin/isolate_holder.cc View 3 chunks +7 lines, -30 lines 0 comments Download
M gin/public/isolate_holder.h View 3 chunks +4 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
jochen (gone - plz use gerrit)
6 years, 3 months ago (2014-09-11 19:09:04 UTC) #1
marja
lgtm
6 years, 3 months ago (2014-09-11 19:29:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/568523002/1
6 years, 3 months ago (2014-09-12 08:48:07 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as 3a583599aafd42c866455c92de5dc8f3955a1b85
6 years, 3 months ago (2014-09-12 09:54:31 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 09:59:02 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b6d92a8f937cbabd2d97c034f873ecbb6e1f26fb
Cr-Commit-Position: refs/heads/master@{#294568}

Powered by Google App Engine
This is Rietveld 408576698