Add phi instruction to Subzero bitcode reader.

src/PNaClTranslator.cpp

 //===- subzero/src/PNaClTranslator.cpp - ICE from bitcode -----------------===//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 //
 // This file implements the PNaCl bitcode file to Ice, to machine code
@@ skipping 805 matching lines @@
         CachedNumGlobalValueIDs(Context->getNumGlobalValueIDs()),
         InstIsTerminating(false) {
     Func->setFunctionName(LLVMFunc->getName());
     Func->setReturnType(Context->convertToIceType(LLVMFunc->getReturnType()));
     Func->setInternal(LLVMFunc->hasInternalLinkage());
     CurrentNode = InstallNextBasicBlock();
     Func->setEntryNode(CurrentNode);
     for (Function::const_arg_iterator ArgI = LLVMFunc->arg_begin(),
                                       ArgE = LLVMFunc->arg_end();
          ArgI != ArgE; ++ArgI) {
-      Func->addArg(NextInstVar(Context->convertToIceType(ArgI->getType())));
+      Func->addArg(getNextInstVar(Context->convertToIceType(ArgI->getType())));
     }
   }
 
   ~FunctionParser() LLVM_OVERRIDE;
 
   // Set the next constant ID to the given constant C.
   void setNextConstantID(Ice::Constant *C) { LocalOperands.push_back(C); }
 
 private:
   // Timer for reading function bitcode and converting to ICE.
@@ skipping 40 matching lines @@
   virtual bool ParseBlock(unsigned BlockID) LLVM_OVERRIDE;
 
   virtual void ProcessRecord() LLVM_OVERRIDE;
 
   virtual void ExitBlock() LLVM_OVERRIDE;
 
   // Creates and appends a new basic block to the list of basic blocks.
   Ice::CfgNode *InstallNextBasicBlock() { return Func->makeNode(); }
 
   // Returns the Index-th basic block in the list of basic blocks.
-  Ice::CfgNode *GetBasicBlock(uint32_t Index) {
+  Ice::CfgNode *getBasicBlock(uint32_t Index) {
     const Ice::NodeList &Nodes = Func->getNodes();
     if (Index >= Nodes.size()) {
       std::string Buffer;
       raw_string_ostream StrBuf(Buffer);
       StrBuf << "Reference to basic block " << Index
              << " not found. Must be less than " << Nodes.size();
       Error(StrBuf.str());
       // TODO(kschimpf) Remove error recovery once implementation complete.
       Index = 0;
     }
     return Nodes[Index];
   }
 
   // Returns the Index-th basic block in the list of basic blocks.
   // Assumes Index corresponds to a branch instruction. Hence, if
   // the branch references the entry block, it also generates a
   // corresponding error.
   Ice::CfgNode *getBranchBasicBlock(uint32_t Index) {
     if (Index == 0) {
       Error("Branch to entry block not allowed");
       // TODO(kschimpf) Remove error recovery once implementation complete.
     }
-    return GetBasicBlock(Index);
+    return getBasicBlock(Index);
   }
 
-  // Generates the next available local variable using the given
-  // type.  Note: if Ty is void, this function returns NULL.
-  Ice::Variable *NextInstVar(Ice::Type Ty) {
-    if (Ty == Ice::IceType_void)
-      return NULL;
+  // Generates the next available local variable using the given type.
+  Ice::Variable *getNextInstVar(Ice::Type Ty) {
+    if (Ty == Ice::IceType_void) {
+      Error("Can't define instruction value using type void");
+      // Recover since we can't throw an exception.
+      Ty = Ice::IceType_i32;
+    }
     Ice::Variable *Var = Func->makeVariable(Ty, CurrentNode);
     LocalOperands.push_back(Var);
     return Var;
   }
 
-  // Converts a relative index (to the next instruction to be read) to
-  // an absolute value index.
-  uint32_t convertRelativeToAbsIndex(int32_t Id) {
-    int32_t AbsNextId = CachedNumGlobalValueIDs + LocalOperands.size();
-    if (Id > 0 && AbsNextId < Id) {
+  // Converts a relative index (wrt to BaseIndex) to an absolute value
+  // index.
+  uint32_t convertRelativeToAbsIndex(int32_t Id, int32_t BaseIndex) {
+    if (BaseIndex < Id) {
       std::string Buffer;
       raw_string_ostream StrBuf(Buffer);
       StrBuf << "Invalid relative value id: " << Id
-             << " (must be <= " << AbsNextId << ")";
+             << " (must be <= " << BaseIndex << ")";
       Error(StrBuf.str());
       // TODO(kschimpf) Remove error recovery once implementation complete.
       return 0;
     }
-    return AbsNextId - Id;
+    return BaseIndex - Id;
   }
 
   // Returns the value referenced by the given value Index.
   Ice::Operand *getOperand(uint32_t Index) {
     if (Index < CachedNumGlobalValueIDs) {
       // TODO(kschimpf): Define implementation.
       report_fatal_error("getOperand of global addresses not implemented");
     }
     uint32_t LocalIndex = Index - CachedNumGlobalValueIDs;
     if (LocalIndex >= LocalOperands.size()) {
       std::string Buffer;
       raw_string_ostream StrBuf(Buffer);
       StrBuf << "Value index " << Index << " out of range. Must be less than "
              << (LocalOperands.size() + CachedNumGlobalValueIDs);
       Error(StrBuf.str());
       report_fatal_error("Unable to continue");
     }
     return LocalOperands[LocalIndex];
   }
 
-  // Returns the relative operand (wrt to next instruction) referenced by
-  // the given value index.
-  Ice::Operand *getRelativeOperand(uint32_t Index) {
-    return getOperand(convertRelativeToAbsIndex(Index));
+  // Returns the relative operand (wrt to BaseIndex) referenced by
+  // the given value Index.
+  Ice::Operand *getRelativeOperand(int32_t Index, int32_t BaseIndex) {
+    return getOperand(convertRelativeToAbsIndex(Index, BaseIndex));
+  }
+
+  // Returns the absolute index of the next value generating instruction.
+  uint32_t getNextInstIndex() const {
+    return CachedNumGlobalValueIDs + LocalOperands.size();
   }
 
   // Generates type error message for binary operator Op
   // operating on Type OpTy.
   void ReportInvalidBinaryOp(Ice::InstArithmetic::OpKind Op, Ice::Type OpTy);
 
   // Validates if integer logical Op, for type OpTy, is valid.
   // Returns true if valid. Otherwise generates error message and
   // returns false.
   bool isValidIntegerLogicalOp(Ice::InstArithmetic::OpKind Op, Ice::Type OpTy) {
@@ skipping 338 matching lines @@
   raw_string_ostream StrBuf(Buffer);
   StrBuf << "Invalid operator type for " << Ice::InstArithmetic::getOpName(Op)
          << ". Found " << OpTy;
   Error(StrBuf.str());
 }
 
 void FunctionParser::ProcessRecord() {
   const NaClBitcodeRecord::RecordVector &Values = Record.GetValues();
   if (InstIsTerminating) {
     InstIsTerminating = false;
-    CurrentNode = GetBasicBlock(++CurrentBbIndex);
+    CurrentNode = getBasicBlock(++CurrentBbIndex);
   }
-  Ice::Inst *Inst = NULL;
+  // The base index for relative indexing.
+  int32_t BaseIndex = getNextInstIndex();
   switch (Record.GetCode()) {
   case naclbitc::FUNC_CODE_DECLAREBLOCKS: {
     // DECLAREBLOCKS: [n]
     if (!isValidRecordSize(1, "function block count"))
       return;
     if (Func->getNodes().size() != 1) {
       Error("Duplicate function block count record");
       return;
     }
     uint32_t NumBbs = Values[0];
     if (NumBbs == 0) {
       Error("Functions must contain at least one basic block.");
       // TODO(kschimpf) Remove error recovery once implementation complete.
       NumBbs = 1;
     }
     // Install the basic blocks, skipping bb0 which was created in the
     // constructor.
     for (size_t i = 1; i < NumBbs; ++i)
       InstallNextBasicBlock();
     break;
   }
   case naclbitc::FUNC_CODE_INST_BINOP: {
     // BINOP: [opval, opval, opcode]
     if (!isValidRecordSize(3, "function block binop"))
       return;
-    Ice::Operand *Op1 = getRelativeOperand(Values[0]);
-    Ice::Operand *Op2 = getRelativeOperand(Values[1]);
+    Ice::Operand *Op1 = getRelativeOperand(Values[0], BaseIndex);
+    Ice::Operand *Op2 = getRelativeOperand(Values[1], BaseIndex);
     Ice::Type Type1 = Op1->getType();
     Ice::Type Type2 = Op2->getType();
     if (Type1 != Type2) {
       std::string Buffer;
       raw_string_ostream StrBuf(Buffer);
       StrBuf << "Binop argument types differ: " << Type1 << " and " << Type2;
       Error(StrBuf.str());
       // TODO(kschimpf) Remove error recovery once implementation complete.
       Op2 = Op1;
     }
 
     Ice::InstArithmetic::OpKind Opcode;
     if (!convertBinopOpcode(Values[2], Type1, Opcode))
       return;
-    Ice::Variable *Dest = NextInstVar(Type1);
-    Inst = Ice::InstArithmetic::create(Func, Opcode, Dest, Op1, Op2);
+    CurrentNode->appendInst(
+        Ice::InstArithmetic::create(
+            Func, Opcode, getNextInstVar(Type1), Op1, Op2));
     break;
   }
   case naclbitc::FUNC_CODE_INST_CAST: {
     // CAST: [opval, destty, castopc]
     if (!isValidRecordSize(3, "function block cast"))
       return;
-    Ice::Operand *Src = getRelativeOperand(Values[0]);
+    Ice::Operand *Src = getRelativeOperand(Values[0], BaseIndex);
     Type *CastType = Context->getTypeByID(Values[1]);
     Instruction::CastOps LLVMCastOp;
     Ice::InstCast::OpKind CastKind;
     if (!naclbitc::DecodeCastOpcode(Values[2], LLVMCastOp) ||
         !convertLLVMCastOpToIceOp(LLVMCastOp, CastKind)) {
       std::string Buffer;
       raw_string_ostream StrBuf(Buffer);
       StrBuf << "Cast opcode not understood: " << Values[2];
       Error(StrBuf.str());
       return;
     }
     Type *SrcType = Context->convertToLLVMType(Src->getType());
     if (!CastInst::castIsValid(LLVMCastOp, SrcType, CastType)) {
       std::string Buffer;
       raw_string_ostream StrBuf(Buffer);
       StrBuf << "Illegal cast: " << Instruction::getOpcodeName(LLVMCastOp)
              << " " << *SrcType << " to " << *CastType;
       Error(StrBuf.str());
       return;
     }
-    Ice::Variable *Dest = NextInstVar(Context->convertToIceType(CastType));
-    Inst = Ice::InstCast::create(Func, CastKind, Dest, Src);
+    CurrentNode->appendInst(
+        Ice::InstCast::create(
+            Func, CastKind, getNextInstVar(Context->convertToIceType(CastType)),
+            Src));
     break;
   }
   case naclbitc::FUNC_CODE_INST_VSELECT: {
     // VSELECT: [opval, opval, pred]
-    Ice::Operand *ThenVal = getOperand(convertRelativeToAbsIndex(Values[0]));
+    Ice::Operand *ThenVal = getRelativeOperand(Values[0], BaseIndex);
     Ice::Type ThenType = ThenVal->getType();
-    Ice::Operand *ElseVal = getOperand(convertRelativeToAbsIndex(Values[1]));
+    Ice::Operand *ElseVal = getRelativeOperand(Values[1], BaseIndex);
     Ice::Type ElseType = ElseVal->getType();
     if (ThenType != ElseType) {
       std::string Buffer;
       raw_string_ostream StrBuf(Buffer);
       StrBuf << "Select operands not same type. Found " << ThenType << " and "
              << ElseType;
       Error(StrBuf.str());
       return;
     }
-    Ice::Operand *CondVal = getOperand(convertRelativeToAbsIndex(Values[2]));
+    Ice::Operand *CondVal = getRelativeOperand(Values[2], BaseIndex);
     Ice::Type CondType = CondVal->getType();
     if (isVectorType(CondType)) {
       if (!isVectorType(ThenType) ||
           typeElementType(CondType) != Ice::IceType_i1 ||
           typeNumElements(ThenType) != typeNumElements(CondType)) {
         std::string Buffer;
         raw_string_ostream StrBuf(Buffer);
         StrBuf << "Select condition " << CondType
                << " not allowed for values of type " << ThenType;
         Error(StrBuf.str());
         return;
       }
     } else if (CondVal->getType() != Ice::IceType_i1) {
       std::string Buffer;
       raw_string_ostream StrBuf(Buffer);
       StrBuf << "Select condition not type i1. Found: " << CondVal->getType();
       Error(StrBuf.str());
       return;
     }
-    Ice::Variable *DestVal = NextInstVar(ThenType);
-    Inst = Ice::InstSelect::create(Func, DestVal, CondVal, ThenVal, ElseVal);
+    CurrentNode->appendInst(
+        Ice::InstSelect::create(
+            Func, getNextInstVar(ThenType), CondVal, ThenVal, ElseVal));
     break;
   }
   case naclbitc::FUNC_CODE_INST_EXTRACTELT: {
     // EXTRACTELT: [opval, opval]
     if (!isValidRecordSize(2, "function block extract element"))
       return;
-    Ice::Operand *Vec = getRelativeOperand(Values[0]);
+    Ice::Operand *Vec = getRelativeOperand(Values[0], BaseIndex);
     Ice::Type VecType = Vec->getType();
     if (!Ice::isVectorType(VecType)) {
       std::string Buffer;
       raw_string_ostream StrBuf(Buffer);
       StrBuf << "Extractelement not on vector. Found: " << Vec;
       Error(StrBuf.str());
     }
-    Ice::Operand *Index = getRelativeOperand(Values[1]);
+    Ice::Operand *Index = getRelativeOperand(Values[1], BaseIndex);
     if (Index->getType() != Ice::IceType_i32) {
       std::string Buffer;
       raw_string_ostream StrBuf(Buffer);
       StrBuf << "Extractelement index not i32. Found: " << Index;
       Error(StrBuf.str());
     }
     // TODO(kschimpf): Restrict index to a legal constant index (once
     // constants can be defined).
-    Ice::Variable *Dest = NextInstVar(typeElementType(VecType));
-    Inst = Ice::InstExtractElement::create(Func, Dest, Vec, Index);
+    CurrentNode->appendInst(
+        Ice::InstExtractElement::create(
+            Func, getNextInstVar(typeElementType(VecType)), Vec, Index));
     break;
   }
   case naclbitc::FUNC_CODE_INST_INSERTELT: {
     // INSERTELT: [opval, opval, opval]
     if (!isValidRecordSize(3, "function block insert element"))
       return;
-    Ice::Operand *Vec = getRelativeOperand(Values[0]);
+    Ice::Operand *Vec = getRelativeOperand(Values[0], BaseIndex);
     Ice::Type VecType = Vec->getType();
     if (!Ice::isVectorType(VecType)) {
       std::string Buffer;
       raw_string_ostream StrBuf(Buffer);
       StrBuf << "Insertelement not on vector. Found: " << Vec;
       Error(StrBuf.str());
     }
-    Ice::Operand *Elt = getRelativeOperand(Values[1]);
+    Ice::Operand *Elt = getRelativeOperand(Values[1], BaseIndex);
     Ice::Type EltType = Elt->getType();
     if (EltType != typeElementType(VecType)) {
       std::string Buffer;
       raw_string_ostream StrBuf(Buffer);
       StrBuf << "Insertelement element not " << typeElementType(VecType)
              << ". Found: " << Elt;
       Error(StrBuf.str());
     }
-    Ice::Operand *Index = getRelativeOperand(Values[2]);
+    Ice::Operand *Index = getRelativeOperand(Values[2], BaseIndex);
     if (Index->getType() != Ice::IceType_i32) {
       std::string Buffer;
       raw_string_ostream StrBuf(Buffer);
       StrBuf << "Insertelement index not i32. Found: " << Index;
       Error(StrBuf.str());
     }
     // TODO(kschimpf): Restrict index to a legal constant index (once
     // constants can be defined).
-    Ice::Variable *Dest = NextInstVar(EltType);
-    Inst = Ice::InstInsertElement::create(Func, Dest, Vec, Elt, Index);
+    CurrentNode->appendInst(
+        Ice::InstInsertElement::create(
+            Func, getNextInstVar(EltType), Vec, Elt, Index));
     break;
   }
   case naclbitc::FUNC_CODE_INST_CMP2: {
     // CMP2: [opval, opval, pred]
     if (!isValidRecordSize(3, "function block compare"))
       return;
-    Ice::Operand *Op1 = getRelativeOperand(Values[0]);
-    Ice::Operand *Op2 = getRelativeOperand(Values[1]);
+    Ice::Operand *Op1 = getRelativeOperand(Values[0], BaseIndex);
+    Ice::Operand *Op2 = getRelativeOperand(Values[1], BaseIndex);
     Ice::Type Op1Type = Op1->getType();
     Ice::Type Op2Type = Op2->getType();
     if (Op1Type != Op2Type) {
       std::string Buffer;
       raw_string_ostream StrBuf(Buffer);
       StrBuf << "Compare argument types differ: " << Op1Type
              << " and " << Op2Type;
       Error(StrBuf.str());
       // TODO(kschimpf) Remove error recovery once implementation complete.
       Op2 = Op1;
     }
     Ice::Type DestType = getCompareResultType(Op1Type);
     if (DestType == Ice::IceType_void) {
       std::string Buffer;
       raw_string_ostream StrBuf(Buffer);
       StrBuf << "Compare not defined for type " << Op1Type;
       Error(StrBuf.str());
       return;
     }
-    Ice::Variable *Dest = NextInstVar(DestType);
+    Ice::Variable *Dest = getNextInstVar(DestType);
     if (isIntegerType(Op1Type)) {
       Ice::InstIcmp::ICond Cond;
       if (!convertNaClBitcICmpOpToIce(Values[2], Cond)) {
         std::string Buffer;
         raw_string_ostream StrBuf(Buffer);
         StrBuf << "Compare record contains unknown integer predicate index: "
                << Values[2];
         Error(StrBuf.str());
         // TODO(kschimpf) Remove error recovery once implementation complete.
         Cond = Ice::InstIcmp::Eq;
       }
-      Inst = Ice::InstIcmp::create(Func, Cond,  Dest, Op1, Op2);
+      CurrentNode->appendInst(
+          Ice::InstIcmp::create(Func, Cond, Dest, Op1, Op2));
     } else if (isFloatingType(Op1Type)){
       Ice::InstFcmp::FCond Cond;
       if (!convertNaClBitcFCompOpToIce(Values[2], Cond)) {
         std::string Buffer;
         raw_string_ostream StrBuf(Buffer);
         StrBuf << "Compare record contains unknown float predicate index: "
                << Values[2];
         Error(StrBuf.str());
         // TODO(kschimpf) Remove error recovery once implementation complete.
         Cond = Ice::InstFcmp::False;
       }
-      Inst = Ice::InstFcmp::create(Func, Cond, Dest, Op1, Op2);
+      CurrentNode->appendInst(
+          Ice::InstFcmp::create(Func, Cond, Dest, Op1, Op2));
     } else {
       // Not sure this can happen, but be safe.
       std::string Buffer;
       raw_string_ostream StrBuf(Buffer);
       StrBuf << "Compare on type not understood: " << Op1Type;
       Error(StrBuf.str());
       return;
     }
     break;
   }
   case naclbitc::FUNC_CODE_INST_RET: {
     // RET: [opval?]
     if (!isValidRecordSizeInRange(0, 1, "function block ret"))
       return;
     if (Values.size() == 0) {
-      Inst = Ice::InstRet::create(Func);
+      CurrentNode->appendInst(Ice::InstRet::create(Func));
     } else {
-      Inst = Ice::InstRet::create(Func, getRelativeOperand(Values[0]));
+      CurrentNode->appendInst(
+          Ice::InstRet::create(Func, getRelativeOperand(Values[0], BaseIndex)));
     }
     InstIsTerminating = true;
     break;
   }
   case naclbitc::FUNC_CODE_INST_BR: {
     if (Values.size() == 1) {
       // BR: [bb#]
       Ice::CfgNode *Block = getBranchBasicBlock(Values[0]);
       if (Block == NULL)
         return;
-      Inst = Ice::InstBr::create(Func, Block);
+      CurrentNode->appendInst(Ice::InstBr::create(Func, Block));
     } else {
       // BR: [bb#, bb#, opval]
       if (!isValidRecordSize(3, "function block branch"))
         return;
-      Ice::Operand *Cond = getRelativeOperand(Values[2]);
+      Ice::Operand *Cond = getRelativeOperand(Values[2], BaseIndex);
       if (Cond->getType() != Ice::IceType_i1) {
         std::string Buffer;
         raw_string_ostream StrBuf(Buffer);
         StrBuf << "Branch condition not i1";
         Error(StrBuf.str());
         return;
       }
       Ice::CfgNode *ThenBlock = getBranchBasicBlock(Values[0]);
       Ice::CfgNode *ElseBlock = getBranchBasicBlock(Values[1]);
       if (ThenBlock == NULL || ElseBlock == NULL)
         return;
-      Inst = Ice::InstBr::create(Func, Cond, ThenBlock, ElseBlock);
+      CurrentNode->appendInst(
+          Ice::InstBr::create(Func, Cond, ThenBlock, ElseBlock));
     }
     InstIsTerminating = true;
     break;
   }
+  case naclbitc::FUNC_CODE_INST_PHI: {
+    // PHI: [ty, val0,bb0, ...]

[jvoung (off chromium), 2014/09/11 19:14:43]

add a space between val0, bb0 ?

[Jim Stichnoth, 2014/09/11 19:31:29]

I assumed that was intentional grouping, e.g.
  [ty, val0,bb0, val1,bb1, val2,bb2, ...]

[Karl, 2014/09/11 21:43:04]

Actually, the space probably be added. Clarifying ... by adding pair "valN, bbN
at end.

+    if (!isValidRecordSizeAtLeast(3, "function block phi"))
+      return;
+    if ((Values.size() & 0x1) == 0) {
+      // Not an odd number of values.
+      std::string Buffer;
+      raw_string_ostream StrBuf(Buffer);
+      StrBuf << "function block phi record size not valid: " << Values.size();
+      Error(StrBuf.str());
+      return;
+    }
+    unsigned NumValues = Values.size()/2;

[Jim Stichnoth, 2014/09/11 18:26:40]

Maybe use "Values.size() >> 1" to make it a little more clear that you're
discarding the odd bit?

Also, if you just move this expression into the InstPhi::create() call, you
won't even have to change "unsigned" to "Ice::SizeT". :)

[Karl, 2014/09/11 21:43:04]

Done.

+    Ice::Type Ty = Context->convertToIceType(Context->getTypeByID(Values[0]));
+    if (Ty == Ice::IceType_void) {
+      Error("Phi record using type void not allowed");
+      return;
+    }
+    Ice::Variable *Dest = getNextInstVar(Ty);
+    Ice::InstPhi *Phi =
+        Ice::InstPhi::create(Func, NumValues, Dest);
+    for (unsigned i = 1, e = Values.size(); i < e; i += 2) {
+      Ice::Operand *Op =
+          getRelativeOperand(NaClDecodeSignRotatedValue(Values[i]), BaseIndex);
+      if (Op->getType() != Ty) {
+        std::string Buffer;
+        raw_string_ostream StrBuf(Buffer);
+        StrBuf << "Phi node expects type " << Ty << " but found: " << Op;

[Jim Stichnoth, 2014/09/11 18:26:40]

Nit: maybe "operand" or "instruction" instead of "node"?

[Karl, 2014/09/11 21:43:04]

Done.

+        Error(StrBuf.str());
+        return;
+      }
+      Phi->addArgument(Op, getBasicBlock(Values[i+1]));

[Jim Stichnoth, 2014/09/11 18:26:40]

hmm, did clang-format really allow "i+1" without spaces? :)

[Karl, 2014/09/11 21:43:04]

Done.

+    }
+    CurrentNode->appendInst(Phi);
+    break;
+  }
   case naclbitc::FUNC_CODE_INST_ALLOCA: {
     // ALLOCA: [Size, align]
     if (!isValidRecordSize(2, "function block alloca"))
       return;
-    Ice::Operand *ByteCount = getRelativeOperand(Values[0]);
+    Ice::Operand *ByteCount = getRelativeOperand(Values[0], BaseIndex);
     if (ByteCount->getType() != Ice::IceType_i32) {
       std::string Buffer;
       raw_string_ostream StrBuf(Buffer);
       StrBuf << "Alloca on non-i32 value. Found: " << ByteCount;
       Error(StrBuf.str());
       return;
     }
     unsigned Alignment;
     extractAlignment("Alloca", Values[1], Alignment);
-    Ice::Variable *Dest = NextInstVar(Context->getIcePointerType());
-    Inst = Ice::InstAlloca::create(Func, ByteCount, Alignment, Dest);
+    CurrentNode->appendInst(
+        Ice::InstAlloca::create(Func, ByteCount, Alignment,
+                                getNextInstVar(Context->getIcePointerType())));
     break;
   }
   case naclbitc::FUNC_CODE_INST_LOAD: {
     // LOAD: [address, align, ty]
     if (!isValidRecordSize(3, "function block load"))
       return;
-    Ice::Operand *Address = getRelativeOperand(Values[0]);
+    Ice::Operand *Address = getRelativeOperand(Values[0], BaseIndex);
     if (!isValidPointerType(Address, "Load"))
       return;
     unsigned Alignment;
     extractAlignment("Load", Values[1], Alignment);
     Ice::Type Ty = Context->convertToIceType(Context->getTypeByID(Values[2]));
     if (!isValidLoadStoreAlignment(Alignment, Ty, "Load"))
       return;
-    Ice::Variable *Dest = NextInstVar(Ty);
-    Inst = Ice::InstLoad::create(Func, Dest, Address, Alignment);
+    CurrentNode->appendInst(
+        Ice::InstLoad::create(Func, getNextInstVar(Ty), Address, Alignment));
     break;
   }
   case naclbitc::FUNC_CODE_INST_STORE: {
     // STORE: [address, value, align]
     if (!isValidRecordSize(3, "function block store"))
       return;
-    Ice::Operand *Address = getRelativeOperand(Values[0]);
+    Ice::Operand *Address = getRelativeOperand(Values[0], BaseIndex);
     if (!isValidPointerType(Address, "Store"))
       return;
-    Ice::Operand *Value = getRelativeOperand(Values[1]);
+    Ice::Operand *Value = getRelativeOperand(Values[1], BaseIndex);
     unsigned Alignment;
     extractAlignment("Store", Values[2], Alignment);
     if (!isValidLoadStoreAlignment(Alignment, Value->getType(), "Store"))
       return;
-    Inst = Ice::InstStore::create(Func, Value, Address, Alignment);
+    CurrentNode->appendInst(
+        Ice::InstStore::create(Func, Value, Address, Alignment));
     break;
   }
   default:
     // Generate error message!
     BlockParserBaseClass::ProcessRecord();
     break;
   }
-  if (Inst)
-    CurrentNode->appendInst(Inst);
 }
 
 /// Parses constants within a function block.
 class ConstantsParser : public BlockParserBaseClass {
   ConstantsParser(const ConstantsParser &) LLVM_DELETED_FUNCTION;
   ConstantsParser &operator=(const ConstantsParser &) LLVM_DELETED_FUNCTION;
 
 public:
   ConstantsParser(unsigned BlockID, FunctionParser *FuncParser)
       : BlockParserBaseClass(BlockID, FuncParser), FuncParser(FuncParser),
@@ skipping 372 matching lines @@
   if (TopLevelBlocks != 1) {
     errs() << IRFilename
            << ": Contains more than one module. Found: " << TopLevelBlocks
            << "\n";
     ErrorStatus = true;
   }
   return;
 }
 
 } // end of namespace Ice