Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: LayoutTests/fast/scroll-behavior/bordered-container-child-scroll.html

Issue 568453002: Removing container's Left & Top border from computed scroll offset bounds. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Modified Layout test to make it more readable and simple Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/scroll-behavior/bordered-container-child-scroll.html
diff --git a/LayoutTests/fast/scroll-behavior/bordered-container-child-scroll.html b/LayoutTests/fast/scroll-behavior/bordered-container-child-scroll.html
new file mode 100644
index 0000000000000000000000000000000000000000..9440c97d6b2613fa9b2f48ff051183191addf638
--- /dev/null
+++ b/LayoutTests/fast/scroll-behavior/bordered-container-child-scroll.html
@@ -0,0 +1,95 @@
+<!DOCTYPE HTML>
+<script src="../../resources/js-test.js"></script>
+<style>
+ .grid {
+ width: 115px;
+ height: 115px;
+ border: solid 5px purple;
+ overflow-x: scroll;
+ overflow-y: scroll;
+ }
+ .row {
+ width: 100px;
+ height: 50px;
+ }
+ .column {
+ width: 48px;
+ height: 48px;
+ outline: solid 1px green;
+ }
+ table, tr, td {
+ border-collapse: collapse;
+ }
+</style>
+<body>
+ <div id="parent" class="grid">
+ <table id="Grid">
+ <tr class="row">
+ <td><div class="column"></div></td>
+ <td><div class="column"></div></td>
+ <td><div class="column"></div></td>
+ <td><div class="column"></div></td>
+ <td><div class="column"></div></td>
+ </tr>
+ <tr class="row">
+ <td><div class="column"></div></td>
+ <td><div class="column"></div></td>
+ <td><div class="column"></div></td>
+ <td><div class="column"></div></td>
+ <td><div class="column"></div></td>
+ </tr>
+ <tr class="row">
+ <td><div class="column"></div></td>
+ <td><div class="column"></div></td>
+ <td><div class="column"></div></td>
+ <td><div class="column"></div></td>
+ <td><div class="column"></div></td>
+ </tr>
+ <tr class="row">
+ <td><div class="column"></div></td>
+ <td><div class="column"></div></td>
+ <td><div class="column"></div></td>
+ <td><div class="column"></div></td>
+ <td><div class="column"></div></td>
+ </tr>
+ <tr class="row">
+ <td><div class="column"></div></td>
+ <td><div class="column"></div></td>
+ <td><div class="column"></div></td>
+ <td><div class="column"></div></td>
+ <td><div class="column"></div></td>
leviw_travelin_and_unemployed 2014/10/11 01:49:16 Can't this be done with a small fraction of the co
Ambarish 2014/10/12 11:59:55 Hi Leviw, I tried to reduce the number of rows and
+ </tr>
+ </table>
+ </div>
+ <script>
+ description('Issue crbug.com/295848: element.scrollIntoViewIfNeeded() does not scroll the entire element render box into view.');
+ // This html comprieses testing if parent border is not affecting scrollLeft and scrollTop value, when a child element is auto scrolled.
+ // When child at row index 8 and column 5 is scrolled into view from bottom left, the scrollTop & scrollLeft should be 75 & 150 respectively.
+ // When child at row index 1 and column 2 is scrolled into view from top right, the scrollTop & scrollLeft should be 25 & 100 respectively.
+
+ if (window.testRunner)
+ testRunner.dumpAsText(true);
+
+ var scrollTop;
+ var scrollLeft;
+ var column;
+ var columnDiv;
+ var row;
+ var parent = document.getElementById("parent");
+ var table = document.getElementById("Grid");
+
+ row = table.rows[3]
+ row.cells[3].scrollIntoViewIfNeeded(false);
+ scrollTop = parent.scrollTop;
+ shouldBeEqualToNumber('scrollTop', 100);
+ scrollLeft = parent.scrollLeft;
+ shouldBeEqualToNumber('scrollLeft', 100);
+
+ row = table.rows[1];
+ row.cells[1].scrollIntoViewIfNeeded(false);
+ scrollTop = parent.scrollTop;
+ shouldBeEqualToNumber('scrollTop', 50);
+ scrollLeft = parent.scrollLeft;
+ shouldBeEqualToNumber('scrollLeft', 50);
+ </script>
+</body>

Powered by Google App Engine
This is Rietveld 408576698