Source/core/rendering/RenderLayerScrollableArea.cpp - Issue 568453002: Removing container's Left & Top border from computed scroll offset bounds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderLayerScrollableArea.cpp

Issue 568453002: Removing container's Left & Top border from computed scroll offset bounds. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: exposeRect() : Removing borderTop from localExposeRect of scrollable box Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/scroll-behavior/bordered-container-child-scroll.html ('K') | « LayoutTests/platform/linux/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderLayerScrollableArea.cpp

diff --git a/Source/core/rendering/RenderLayerScrollableArea.cpp b/Source/core/rendering/RenderLayerScrollableArea.cpp

index 308e7016e74a1e8f5cd0b1f9acb5855104f009e1..96ae508f9bd07b4068bda7fbdbb8f59d04f9550e 100644

--- a/Source/core/rendering/RenderLayerScrollableArea.cpp

+++ b/Source/core/rendering/RenderLayerScrollableArea.cpp

@@ -1381,6 +1381,9 @@ void RenderLayerScrollableArea::resize(const PlatformEvent& evt, const LayoutSiz

LayoutRect RenderLayerScrollableArea::exposeRect(const LayoutRect& rect, const ScrollAlignment& alignX, const ScrollAlignment& alignY)

{

LayoutRect localExposeRect(box().absoluteToLocalQuad(FloatQuad(FloatRect(rect)), UseTransforms).boundingBox());

+ if (box().borderTop() > 0)

+ localExposeRect.setY(localExposeRect.y().toInt() - box().borderTop());

LayoutRect layerBounds(0, 0, box().clientWidth(), box().clientHeight());

pals 2014/09/24 12:31:36 What about borderLeft()? We should really change (

LayoutRect r = ScrollAlignment::getRectToExpose(layerBounds, localExposeRect, alignX, alignY);