LayoutTests/fast/scroll-behavior/bordered-container-child-scroll.html - Issue 568453002: Removing container's Left & Top border from computed scroll offset bounds.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/scroll-behavior/bordered-container-child-scroll.html

Issue 568453002: Removing container's Left & Top border from computed scroll offset bounds. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: exposeRect() : Removing borderTop from localExposeRect of scrollable box Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/forms/listbox-selection-2-expected.txt ('k') | LayoutTests/fast/scroll-behavior/bordered-container-child-scroll-expected.txt » ('j') | Source/core/rendering/RenderLayerScrollableArea.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE HTML>

	2 <html>

	3 <head>

	4 <script src="../../resources/js-test.js"></script>

	5 <style type="text/css">

	6 .grid {

	7 width: 150px;

	8 height: 150px;

	9 border: solid 5px purple;

	10 overflow: auto;
	pals 2014/09/24 12:31:35 Indentations. Indentations.
	11 }

	12 .row {

	13 height: 25px;

	14 box-sizing: border-box;

	15 background: black;

	16 outline: solid 1px green;

	17 outline-offset: -1px;

	18 color: white;

	19 }

	20 </style>

	21 </head>

	22 <body>
	pals 2014/09/24 12:31:36 Not needed. Not needed.
	23 <p id="description"></p>
	pals 2014/09/24 12:31:35 Not needed. Not needed.
	24 <div id="console"></div>
	pals 2014/09/24 12:31:35 Not needed. Not needed.
	25 <script>
	pals 2014/09/24 12:31:35 Put it in <head> Put it in <head>
	26 description('Issue crbug.com/295848: element.scrollIntoViewIfNeeded( ) does not scroll the entire element render box into view.');

	27 var scrollTop = 0;

	28 var grid = document.createElement('div');

	29 grid.id = "Grid";

	30 grid.className = 'grid';

	31 document.body.appendChild(grid);

	32 for (var i = 0; i < 10; ++i) {

	33 var row = document.createElement('div');

	34 row.className = 'row';

	35 if(i == 1 \| i == 8)

	36 row.style.backgroundColor = "white";

	37 grid.appendChild(row);

	38 }

	39

	40 grid.scrollTop = 100;

	41 var row = grid.getElementsByTagName('div')[1];

	42 row.scrollIntoViewIfNeeded(false);

	43 scrollTop = grid.scrollTop;

	44 shouldBeEqualToNumber('scrollTop', 25);

	45

	46 row = grid.getElementsByTagName('div')[8];

	47 row.scrollIntoViewIfNeeded(false);

	48 scrollTop = grid.scrollTop;

	49 shouldBeEqualToNumber('scrollTop', 75);
	pals 2014/09/24 12:31:36 Can you put a comment about significance of number Can you put a comment about significance of number 75.
	50

	51 </script>

	52 </body>

	53 </html>

OLD	NEW