Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(766)

Issue 568443002: [New Multicolumn] A renderer can't be both a parent and a sibling of another renderer. (Closed)

Created:
6 years, 3 months ago by mstensho (USE GERRIT)
Modified:
6 years, 2 months ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rune+blink, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

[New Multicolumn] A renderer can't be both a parent and a sibling of another renderer. In addChild(), beforeChild needs to be a descendant of the parent that's attempting to insert a renderer. When redirecting renderer insertion to a child RenderMultiColumnFlowThread, update beforeChild if it's set to said RenderMultiColumnFlowThread as well. BUG=358597 R=leviw@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183315

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
A + LayoutTests/fast/multicol/empty-list-item.html View 1 chunk +2 lines, -4 lines 0 comments Download
A + LayoutTests/fast/multicol/empty-list-item-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/RenderBlockFlow.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
mstensho (USE GERRIT)
6 years, 3 months ago (2014-09-11 13:15:45 UTC) #1
mstensho (USE GERRIT)
6 years, 3 months ago (2014-09-11 13:18:41 UTC) #3
mstensho (USE GERRIT)
I'm aware of https://code.google.com/p/chromium/issues/detail?id=417556 , but I'm not sure if we should wait for that, ...
6 years, 2 months ago (2014-09-25 06:31:50 UTC) #5
mstensho (USE GERRIT)
6 years, 2 months ago (2014-10-06 12:48:09 UTC) #6
leviw_travelin_and_unemployed
Okay. LGTM.
6 years, 2 months ago (2014-10-06 18:17:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/568443002/1
6 years, 2 months ago (2014-10-06 19:19:37 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/59906)
6 years, 2 months ago (2014-10-06 21:08:23 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/568443002/1
6 years, 2 months ago (2014-10-06 21:16:12 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/59906)
6 years, 2 months ago (2014-10-06 21:26:09 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/568443002/1
6 years, 2 months ago (2014-10-07 07:16:39 UTC) #17
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 08:20:18 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183315

Powered by Google App Engine
This is Rietveld 408576698