Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 568433002: CSP: Convert CSPSource constructor bools into a enum. (Closed)

Created:
6 years, 3 months ago by Mike West
Modified:
6 years, 3 months ago
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

CSP: Convert CSPSource constructor bools into a enum. Rather than passing the wildcard disposition of CSPSource's hosts and ports as booleans, we should have an enum that allows us to figure out hat we mean at the callsite. This patch adds CSPSource::WildcardDisposition in order to make this clear. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181821

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -28 lines) Patch
M Source/core/frame/csp/CSPSource.h View 2 chunks +8 lines, -3 lines 0 comments Download
M Source/core/frame/csp/CSPSource.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/frame/csp/CSPSourceList.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/frame/csp/CSPSourceList.cpp View 9 chunks +15 lines, -15 lines 0 comments Download
M Source/core/frame/csp/ContentSecurityPolicy.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Mike West
Enum! WDYT? -mike
6 years, 3 months ago (2014-09-11 13:14:31 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 3 months ago (2014-09-11 13:20:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/568433002/1
6 years, 3 months ago (2014-09-11 13:49:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 181821
6 years, 3 months ago (2014-09-11 14:17:37 UTC) #6
jianli
6 years, 3 months ago (2014-09-11 17:24:31 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/565723002/ by jianli@chromium.org.

The reason for reverting is: Your patch broke quite a number of webkit tests:
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.8%20%28re...
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.7/builds/....

Powered by Google App Engine
This is Rietveld 408576698