Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: tools/auto_bisect/bisect_utils.py

Issue 568423002: Refactoring and minor corrections: (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | tools/bisect-perf-regression.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Utility functions used by the bisect tool. 5 """Utility functions used by the bisect tool.
6 6
7 This includes functions related to checking out the depot and outputting 7 This includes functions related to checking out the depot and outputting
8 annotations for the Buildbot waterfall. 8 annotations for the Buildbot waterfall.
9 """ 9 """
10 10
(...skipping 361 matching lines...) Expand 10 before | Expand all | Expand 10 after
372 if opts.output_buildbot_annotations: 372 if opts.output_buildbot_annotations:
373 OutputAnnotationStepStart(name) 373 OutputAnnotationStepStart(name)
374 374
375 passed = False 375 passed = False
376 376
377 if not RunGClientAndCreateConfig(opts, custom_deps): 377 if not RunGClientAndCreateConfig(opts, custom_deps):
378 passed_deps_check = True 378 passed_deps_check = True
379 if os.path.isfile(os.path.join('src', FILE_DEPS_GIT)): 379 if os.path.isfile(os.path.join('src', FILE_DEPS_GIT)):
380 cwd = os.getcwd() 380 cwd = os.getcwd()
381 os.chdir('src') 381 os.chdir('src')
382 passed_deps_check = True
383 if passed_deps_check: 382 if passed_deps_check:
384 passed_deps_check = RemoveThirdPartyDirectory('libjingle') 383 passed_deps_check = RemoveThirdPartyDirectory('libjingle')
385 if passed_deps_check: 384 if passed_deps_check:
386 passed_deps_check = RemoveThirdPartyDirectory('skia') 385 passed_deps_check = RemoveThirdPartyDirectory('skia')
387 os.chdir(cwd) 386 os.chdir(cwd)
388 387
389 if passed_deps_check: 388 if passed_deps_check:
390 _CleanupPreviousGitRuns() 389 _CleanupPreviousGitRuns()
391 390
392 RunGClient(['revert']) 391 RunGClient(['revert'])
(...skipping 181 matching lines...) Expand 10 before | Expand all | Expand 10 after
574 return sys.platform.startswith('linux') 573 return sys.platform.startswith('linux')
575 574
576 575
577 def IsMacHost(): 576 def IsMacHost():
578 """Checks whether or not the script is running on Mac. 577 """Checks whether or not the script is running on Mac.
579 578
580 Returns: 579 Returns:
581 True if running on Mac. 580 True if running on Mac.
582 """ 581 """
583 return sys.platform.startswith('darwin') 582 return sys.platform.startswith('darwin')
OLDNEW
« no previous file with comments | « no previous file | tools/bisect-perf-regression.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698