Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: content/browser/devtools/embedded_worker_devtools_agent_host.cc

Issue 568403002: Unify shared and service workers in chrome://inspect, remove service workers iframe. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixed review comments Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/embedded_worker_devtools_agent_host.cc
diff --git a/content/browser/devtools/embedded_worker_devtools_agent_host.cc b/content/browser/devtools/embedded_worker_devtools_agent_host.cc
index 3e83b060a7b42c0192b9a08488f5f7ac49245bbf..da047265f657ae5c7d8331aeaf4a8d92adb32d1a 100644
--- a/content/browser/devtools/embedded_worker_devtools_agent_host.cc
+++ b/content/browser/devtools/embedded_worker_devtools_agent_host.cc
@@ -68,7 +68,13 @@ DevToolsAgentHost::Type EmbeddedWorkerDevToolsAgentHost::GetType() {
}
std::string EmbeddedWorkerDevToolsAgentHost::GetTitle() {
- return shared_worker_ ? base::UTF16ToUTF8(shared_worker_->name()) : "";
+ if (shared_worker_ && shared_worker_->name().length())
+ return base::UTF16ToUTF8(shared_worker_->name());
+ if (RenderProcessHost* host = RenderProcessHost::FromID(worker_id_.first)) {
+ return base::StringPrintf("Worker pid:%d",
+ base::GetProcId(host->GetHandle()));
+ }
+ return "";
}
GURL EmbeddedWorkerDevToolsAgentHost::GetURL() {
« no previous file with comments | « chrome/browser/ui/webui/inspect_ui.cc ('k') | content/browser/resources/service_worker/serviceworker_internals.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698