Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 568383002: Ensure the app list search result progress bar is set in SetResult() (Closed)

Created:
6 years, 3 months ago by tapted
Modified:
6 years, 3 months ago
Reviewers:
calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Ensure the app list search result progress bar is set in SetResult() SearchResultView::SetResult() was missing a call to OnPercentDownloadedChanged(). This CL adds one. BUG=402859 Committed: https://crrev.com/a48fbeb71d7b4e66a5fafecf2b81ec6d5f97e1c5 Cr-Commit-Position: refs/heads/master@{#294790}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -10 lines) Patch
M ui/app_list/views/search_result_list_view_unittest.cc View 8 chunks +29 lines, -10 lines 0 comments Download
M ui/app_list/views/search_result_view.h View 2 chunks +5 lines, -0 lines 0 comments Download
M ui/app_list/views/search_result_view.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tapted
6 years, 3 months ago (2014-09-15 04:47:35 UTC) #2
calamity
lgtm
6 years, 3 months ago (2014-09-15 06:50:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/568383002/1
6 years, 3 months ago (2014-09-15 07:03:56 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 0620e511e6bdb50ea8252b900997993dfb221144
6 years, 3 months ago (2014-09-15 07:45:55 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-15 07:48:36 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a48fbeb71d7b4e66a5fafecf2b81ec6d5f97e1c5
Cr-Commit-Position: refs/heads/master@{#294790}

Powered by Google App Engine
This is Rietveld 408576698