GN rules for openmax

GN rules for openmax

BUG=359249
Committed: https://crrev.com/a19ca076f65f03b0cf9576a4e79f90a52e8f5e07
Cr-Commit-Position: refs/heads/master@{#294994}

[cjhopman, 2014-09-15 00:24:39]

cjhopman@chromium.org changed reviewers:
+ brettw@chromium.org

[cjhopman, 2014-09-15 00:24:40]

brettw: *

[brettw, 2014-09-15 02:25:46]

lgtm

https://codereview.chromium.org/568363002/diff/20001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/568363002/diff/20001/BUILD.gn#newcode171
BUILD.gn:171: "//third_party/openmax_dl/dl:dl",
Can you remove the ":dl" which should be redundant?

https://codereview.chromium.org/568363002/diff/20001/build/secondary/third_pa...
File build/secondary/third_party/openmax_dl/dl/BUILD.gn (right):

https://codereview.chromium.org/568363002/diff/20001/build/secondary/third_pa...
build/secondary/third_party/openmax_dl/dl/BUILD.gn:7: big_float_fft = true
Can you prefix this with "openmax_" (since all declare_args are global).

https://codereview.chromium.org/568363002/diff/20001/build/secondary/third_pa...
build/secondary/third_party/openmax_dl/dl/BUILD.gn:11: include_dirs = [ "../" ]
You can delete the slash in here.

[cjhopman, 2014-09-16 01:40:32]

https://codereview.chromium.org/568363002/diff/20001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/568363002/diff/20001/BUILD.gn#newcode171
BUILD.gn:171: "//third_party/openmax_dl/dl:dl",
On 2014/09/15 02:25:46, brettw wrote:
> Can you remove the ":dl" which should be redundant?

Done.

https://codereview.chromium.org/568363002/diff/20001/build/secondary/third_pa...
File build/secondary/third_party/openmax_dl/dl/BUILD.gn (right):

https://codereview.chromium.org/568363002/diff/20001/build/secondary/third_pa...
build/secondary/third_party/openmax_dl/dl/BUILD.gn:7: big_float_fft = true
On 2014/09/15 02:25:46, brettw wrote:
> Can you prefix this with "openmax_" (since all declare_args are global).

Done.

https://codereview.chromium.org/568363002/diff/20001/build/secondary/third_pa...
build/secondary/third_party/openmax_dl/dl/BUILD.gn:11: include_dirs = [ "../" ]
On 2014/09/15 02:25:46, brettw wrote:
> You can delete the slash in here.

Done.

[cjhopman, 2014-09-16 01:40:35]

The CQ bit was checked by cjhopman@chromium.org

[commit-bot: I haz the power, 2014-09-16 01:42:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/568363002/40001

[commit-bot: I haz the power, 2014-09-16 02:47:19]

Committed patchset #3 (id:40001) as 778f13914ed01e88eddacc31a05031b9375c2d6e

[commit-bot: I haz the power, 2014-09-16 02:50:16]

Patchset 3 (id:??) landed as
https://crrev.com/a19ca076f65f03b0cf9576a4e79f90a52e8f5e07
Cr-Commit-Position: refs/heads/master@{#294994}