ui/views/bubble/bubble_border.cc - Issue 568343002: Removed a few manual roundrect path creations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/bubble/bubble_border.cc

Issue 568343002: Removed a few manual roundrect path creations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address reviewer comments Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/bubble/bubble_border.cc

diff --git a/ui/views/bubble/bubble_border.cc b/ui/views/bubble/bubble_border.cc

index d7adfb6573033016bf9b140d09c01aebb5e7db3d..0fd0e3cebc663746f79557e8902d71767b92c8e7 100644

--- a/ui/views/bubble/bubble_border.cc

+++ b/ui/views/bubble/bubble_border.cc

@@ -351,9 +351,7 @@ void BubbleBackground::Paint(gfx::Canvas* canvas, views::View* view) const {

gfx::Rect bounds(view->GetLocalBounds());

bounds.Inset(border_->GetInsets());

- SkScalar radius = SkIntToScalar(border_->GetBorderCornerRadius());

- path.addRoundRect(gfx::RectToSkRect(bounds), radius, radius);

- canvas->DrawPath(path, paint);

+ canvas->DrawRoundRect(bounds, border_->GetBorderCornerRadius(), paint);

}

} // namespace views

« no previous file with comments | « chrome/browser/ui/views/status_bubble_views.cc ('k') | ui/views/bubble/tray_bubble_view.cc » ('j') | no next file with comments »