Use base::PostTaskAndReplyWithResults() in more places.

Use base::PostTaskAndReplyWithResults() in more places.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236953

[Lei Zhang, 2013-11-04 19:50:46]

jam: PTAL at contents/public when you get a chance. I'll get chrome/ reviewers
upon your approval.

Too many callers see PostBlockingPoolTaskAndReply() but forget the existence of
base::PostTaskAndReplyWithResult(), so they end up manually allocating memory to
use between the "task" and "reply" callbacks.

[jam, 2013-11-05 18:25:11]

On 2013/11/04 19:50:46, Lei Zhang wrote:
> jam: PTAL at contents/public when you get a chance. I'll get chrome/ reviewers
> upon your approval.
> 
> Too many callers see PostBlockingPoolTaskAndReply() but forget the existence
of
> base::PostTaskAndReplyWithResult(), so they end up manually allocating memory
to
> use between the "task" and "reply" callbacks.

In general we put stuff in content/public because there's no other way of doing
this. It looks like this is a convenience wrapper around a method in base and
passing in the blocing pool? It seems that all callers can do what this inline
method does?

[Lei Zhang, 2013-11-05 18:39:08]

On 2013/11/05 18:25:11, jam wrote:
> On 2013/11/04 19:50:46, Lei Zhang wrote:
> > jam: PTAL at contents/public when you get a chance. I'll get chrome/
reviewers
> > upon your approval.
> > 
> > Too many callers see PostBlockingPoolTaskAndReply() but forget the existence
> of
> > base::PostTaskAndReplyWithResult(), so they end up manually allocating
memory
> to
> > use between the "task" and "reply" callbacks.
> 
> In general we put stuff in content/public because there's no other way of
doing
> this. It looks like this is a convenience wrapper around a method in base and
> passing in the blocing pool? It seems that all callers can do what this inline
> method does?

Ok, do you mind if I just add a comment in
content/public/browser/browser_thread.h to remind readers about
base::PostTaskAndReplyWithResult() instead?

[jam, 2013-11-07 18:43:53]

On 2013/11/05 18:39:08, Lei Zhang wrote:
> On 2013/11/05 18:25:11, jam wrote:
> > On 2013/11/04 19:50:46, Lei Zhang wrote:
> > > jam: PTAL at contents/public when you get a chance. I'll get chrome/
> reviewers
> > > upon your approval.
> > > 
> > > Too many callers see PostBlockingPoolTaskAndReply() but forget the
existence
> > of
> > > base::PostTaskAndReplyWithResult(), so they end up manually allocating
> memory
> > to
> > > use between the "task" and "reply" callbacks.
> > 
> > In general we put stuff in content/public because there's no other way of
> doing
> > this. It looks like this is a convenience wrapper around a method in base
and
> > passing in the blocing pool? It seems that all callers can do what this
inline
> > method does?
> 
> Ok, do you mind if I just add a comment in
> content/public/browser/browser_thread.h to remind readers about
> base::PostTaskAndReplyWithResult() instead?

sure (sorry just saw this)

[Lei Zhang, 2013-11-07 21:22:17]

jam: contents/ stamp
zelidrag: chromeos bits
bradnelson: nacl
yoz: extensions

[Yoyo Zhou, 2013-11-07 22:16:04]

extensions LGTM

[zel, 2013-11-07 23:50:34]

chromeos LGTM

[jam, 2013-11-11 17:04:08]

lgtm

[bradn, 2013-11-21 23:09:39]

lgtm nacl

[bradnelson, 2013-11-21 23:10:30]

lgtm nacl (@chromium)

[commit-bot: I haz the power, 2013-11-21 23:26:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/56833003/390001

[commit-bot: I haz the power, 2013-11-21 23:45:44]

Retried try job too often on mac_rel for step(s) base_unittests, browser_tests,
interactive_ui_tests, net_unittests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2013-11-23 05:42:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/56833003/780001

[commit-bot: I haz the power, 2013-11-23 19:03:58]

Change committed as 236953