Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Issue 568173004: Use base::StringPairs where appropriate from /chrome (Closed)

Created:
6 years, 3 months ago by limasdf
Modified:
6 years, 3 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, hashimoto+watch_chromium.org, tfarina, eroman, mmenke, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, markusheintz_, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use base::StringPairs where appropriate from /chrome Becuase base/strings/string_split.h defines: typedef std::vector<std::pair<std::string, std::string> > StringPairs; BUG=412250 Committed: https://crrev.com/511524f1f79549928c5c223337abe09c9448ee49 Cr-Commit-Position: refs/heads/master@{#294707}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M chrome/browser/chromeos/drive/resource_metadata_storage_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/content_settings/content_settings_pref_provider.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/identity/gaia_web_auth_flow.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/tracked/tracked_preferences_migration_unittest.cc View 4 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/net_internals/net_internals_ui.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
limasdf
PTAL
6 years, 3 months ago (2014-09-12 22:51:28 UTC) #2
Lei Zhang
lgtm Thanks!
6 years, 3 months ago (2014-09-12 22:53:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/568173004/1
6 years, 3 months ago (2014-09-12 22:59:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as c58cd66adaef9f76f2e6bed4bb82ae6a0e4e4bd6
6 years, 3 months ago (2014-09-13 00:50:24 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-13 00:54:44 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/511524f1f79549928c5c223337abe09c9448ee49
Cr-Commit-Position: refs/heads/master@{#294707}

Powered by Google App Engine
This is Rietveld 408576698