Add Initialize() method to Application with ability to send args using

mojo/public/cpp/application/lib/application_impl.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "mojo/public/cpp/application/application_impl.h"
 
 #include "mojo/public/cpp/application/application_delegate.h"
 #include "mojo/public/cpp/application/lib/service_registry.h"
 #include "mojo/public/cpp/bindings/interface_ptr.h"
 
@@ skipping 10 matching lines @@
     impl_->OnShellError();
   }
 
  private:
   ApplicationImpl* impl_;
   MOJO_DISALLOW_COPY_AND_ASSIGN(ShellPtrWatcher);
 };
 
 ApplicationImpl::ApplicationImpl(ApplicationDelegate* delegate,
                                  ScopedMessagePipeHandle shell_handle)
-    : delegate_(delegate), shell_watch_(NULL) {
+    : initialized_(false), delegate_(delegate), shell_watch_(NULL) {
   BindShell(shell_handle.Pass());
 }
 
 ApplicationImpl::ApplicationImpl(ApplicationDelegate* delegate,
                                  MojoHandle shell_handle)
-    : delegate_(delegate), shell_watch_(NULL) {
+    : initialized_(false), delegate_(delegate), shell_watch_(NULL) {
   BindShell(MakeScopedHandle(MessagePipeHandle(shell_handle)));
 }
 
 void ApplicationImpl::ClearConnections() {
   for (ServiceRegistryList::iterator i(incoming_service_registries_.begin());
       i != incoming_service_registries_.end(); ++i)
     delete *i;
   for (ServiceRegistryList::iterator i(outgoing_service_registries_.begin());
       i != outgoing_service_registries_.end(); ++i)
     delete *i;
   incoming_service_registries_.clear();
   outgoing_service_registries_.clear();
 }
 
 ApplicationImpl::~ApplicationImpl() {
   ClearConnections();
   delete shell_watch_;
 }
 
+void ApplicationImpl::Initialize(Array<String> args) {
+  assert(!initialized_);

[viettrungluu, 2014/09/15 17:26:19]

You can actually use mojo/public/cpp/environment/logging.h here, and thus
MOJO_DCHECK.

[DaveMoore, 2014/09/15 22:35:08]

Done.

+  initialized_ = true;
+  args_ = args.Pass();
+  delegate_->Initialize(this);
+}
+
 ApplicationConnection* ApplicationImpl::ConnectToApplication(
     const String& application_url) {
+  assert(initialized_);

[viettrungluu, 2014/09/15 17:26:19]

"

[DaveMoore, 2014/09/15 22:35:08]

Done.

   ServiceProviderPtr out_service_provider;
   shell_->ConnectToApplication(application_url, Get(&out_service_provider));
   internal::ServiceRegistry* registry = new internal::ServiceRegistry(
       this,
       application_url,
       out_service_provider.Pass());
   if (!delegate_->ConfigureOutgoingConnection(registry)) {
     delete registry;
     return NULL;
   }
   outgoing_service_registries_.push_back(registry);
   return registry;
 }
 
 void ApplicationImpl::BindShell(ScopedMessagePipeHandle shell_handle) {
+  initialized_ = false;

[viettrungluu, 2014/09/15 17:26:19]

I don't think you need this. Maybe a MOJO_DCHECK(!initialized); instead.

[DaveMoore, 2014/09/15 22:35:08]

Removed. At one point this was where I initialized it.
On 2014/09/15 17:26:19, viettrungluu wrote:

   shell_watch_ = new ShellPtrWatcher(this);
   shell_.Bind(shell_handle.Pass());
   shell_.set_client(this);
   shell_.set_error_handler(shell_watch_);
-  delegate_->Initialize(this);
 }
 
 void ApplicationImpl::AcceptConnection(const String& requestor_url,
                                        ServiceProviderPtr service_provider) {
   internal::ServiceRegistry* registry = new internal::ServiceRegistry(
       this, requestor_url, service_provider.Pass());
   if (!delegate_->ConfigureIncomingConnection(registry)) {
     delete registry;
     return;
   }
   incoming_service_registries_.push_back(registry);
 }
 
 }  // namespace mojo