Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Unified Diff: content/public/browser/web_contents_observer.h

Issue 568163004: Remove the use of ProvisionalChangeToMainFrameUrl from supervised user code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/supervised_user/supervised_user_navigation_observer.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/web_contents_observer.h
diff --git a/content/public/browser/web_contents_observer.h b/content/public/browser/web_contents_observer.h
index 65bddd95614a28ec4bc47e47b6ee1567ca91a019..846bf94a4d5d13eb5690fce54e3e909b229fb3b9 100644
--- a/content/public/browser/web_contents_observer.h
+++ b/content/public/browser/web_contents_observer.h
@@ -131,8 +131,16 @@ class CONTENT_EXPORT WebContentsObserver : public IPC::Listener,
// This method is invoked right after the DidStartProvisionalLoadForFrame if
// the provisional load affects the main frame, or if the provisional load
- // was redirected. The latter use case is DEPRECATED. You should listen to
+ // was redirected.
+ //
+ // The latter use case is DEPRECATED. You should listen to
// WebContentsObserver::DidGetRedirectForResourceRequest instead.
+ //
+ // The former use case is redundant; you should use
+ // DidStartProvisionalLoadForFrame instead, and do a check for the main frame.
+ //
+ // As a result, this whole callback is silly and DEPRECATED. Do not use it.
+ // http://crbug.com/78512
virtual void ProvisionalChangeToMainFrameUrl(
const GURL& url,
RenderFrameHost* render_frame_host) {}
« no previous file with comments | « chrome/browser/supervised_user/supervised_user_navigation_observer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698