Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(907)

Issue 568163004: Remove the use of ProvisionalChangeToMainFrameUrl from supervised user code. (Closed)

Created:
6 years, 3 months ago by Avi (use Gerrit)
Modified:
6 years, 3 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, jam, pam+watch_chromium.org, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove the use of ProvisionalChangeToMainFrameUrl from supervised user code. BUG=78512 TEST=no change Committed: https://crrev.com/b25eefd6e4e69cc5b500f54293ba156f2072283c Cr-Commit-Position: refs/heads/master@{#294747}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -18 lines) Patch
M chrome/browser/supervised_user/supervised_user_navigation_observer.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_navigation_observer.cc View 2 chunks +4 lines, -14 lines 0 comments Download
M content/public/browser/web_contents_observer.h View 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Avi (use Gerrit)
Bernhard: please review. The existing use of ProvisionalChangeToMainFrameUrl is silly for lots of reasons. First, ...
6 years, 3 months ago (2014-09-12 22:21:47 UTC) #2
Bernhard Bauer
LGTM, thanks!
6 years, 3 months ago (2014-09-13 08:02:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/568163004/1
6 years, 3 months ago (2014-09-13 14:27:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as fd43f02e816d95df8c3acaf383dfde56b98cb06d
6 years, 3 months ago (2014-09-13 14:55:26 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-13 14:58:13 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b25eefd6e4e69cc5b500f54293ba156f2072283c
Cr-Commit-Position: refs/heads/master@{#294747}

Powered by Google App Engine
This is Rietveld 408576698