Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 568153006: Fix Mac GN build. (Closed)

Created:
6 years, 3 months ago by brettw
Modified:
6 years, 3 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix Mac GN build. These files were being removed twice from the sources. TBR=viettrungluu Committed: https://crrev.com/c859f18fafe3f56da4e59f265915db6d9ad73a33 Cr-Commit-Position: refs/heads/master@{#295600}

Patch Set 1 #

Total comments: 2

Patch Set 2 : comment fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M net/BUILD.gn View 1 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
brettw
6 years, 3 months ago (2014-09-17 17:22:32 UTC) #2
viettrungluu
https://codereview.chromium.org/568153006/diff/1/net/BUILD.gn File net/BUILD.gn (right): https://codereview.chromium.org/568153006/diff/1/net/BUILD.gn#newcode1199 net/BUILD.gn:1199: # These were already removed in the ChromeOS case. ...
6 years, 3 months ago (2014-09-17 23:03:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/568153006/20001
6 years, 3 months ago (2014-09-18 20:16:33 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 3 months ago (2014-09-18 20:16:35 UTC) #7
brettw
https://codereview.chromium.org/568153006/diff/1/net/BUILD.gn File net/BUILD.gn (right): https://codereview.chromium.org/568153006/diff/1/net/BUILD.gn#newcode1199 net/BUILD.gn:1199: # These were already removed in the ChromeOS case. ...
6 years, 3 months ago (2014-09-18 20:22:16 UTC) #8
viettrungluu
lgtm
6 years, 3 months ago (2014-09-18 21:34:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/568153006/20001
6 years, 3 months ago (2014-09-18 22:00:14 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/11999)
6 years, 3 months ago (2014-09-18 22:20:41 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/568153006/20001
6 years, 3 months ago (2014-09-18 23:02:41 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001) as a24f0312f7084636b7cc9d179290e9acd4d28bd0
6 years, 3 months ago (2014-09-18 23:35:02 UTC) #16
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 23:35:35 UTC) #17
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/c859f18fafe3f56da4e59f265915db6d9ad73a33
Cr-Commit-Position: refs/heads/master@{#295600}

Powered by Google App Engine
This is Rietveld 408576698