Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 568143003: Archive browser_tests for dev and official Chromium builds on Mac. (Closed)

Created:
6 years, 3 months ago by anandc
Modified:
6 years, 3 months ago
Reviewers:
Michael Moss
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

This is similar to https://codereview.chromium.org/328423002/ where we started archiving browser_tests for Windows. BUG= Committed: https://crrev.com/33e2bb0f2855f120c7a08f6486fd2c44f9b0d55a Cr-Commit-Position: refs/heads/master@{#294841}

Patch Set 1 #

Patch Set 2 : Fix name of browser_tests binary. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/tools/build/mac/FILES.cfg View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
anandc
Hi Michael, Could you PTAL? I'm not sure what the suffix is for the browser_tests ...
6 years, 3 months ago (2014-09-12 21:49:21 UTC) #2
Michael Moss
On 2014/09/12 21:49:21, anandc wrote: > Hi Michael, > > Could you PTAL? I'm not ...
6 years, 3 months ago (2014-09-12 21:54:51 UTC) #3
anandc
On 2014/09/12 21:54:51, Michael Moss wrote: > On 2014/09/12 21:49:21, anandc wrote: > > Hi ...
6 years, 3 months ago (2014-09-12 23:26:06 UTC) #4
Michael Moss
lgtm
6 years, 3 months ago (2014-09-15 15:38:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/568143003/20001
6 years, 3 months ago (2014-09-15 15:49:24 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 0c513e85eb61fc9f4218f8f335e7e0f4a4c1b16e
6 years, 3 months ago (2014-09-15 17:14:57 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-15 17:19:01 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/33e2bb0f2855f120c7a08f6486fd2c44f9b0d55a
Cr-Commit-Position: refs/heads/master@{#294841}

Powered by Google App Engine
This is Rietveld 408576698