media/filters/video_renderer_impl.cc - Issue 568113003: Switch back to using VideoRenderer::StartPlayingFrom().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/filters/video_renderer_impl.cc

Issue 568113003: Switch back to using VideoRenderer::StartPlayingFrom(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« media/filters/video_renderer_impl.h ('K') | « media/filters/video_renderer_impl.h ('k') | media/filters/video_renderer_impl_unittest.cc » ('j') | media/filters/video_renderer_impl_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/filters/video_renderer_impl.cc

diff --git a/media/filters/video_renderer_impl.cc b/media/filters/video_renderer_impl.cc

index 0e3acbcd55b9d9b50b8f0720f75922fade1b370f..1bd3f270ab92bfaf7688d2b0713f9c7b15f226ec 100644

--- a/media/filters/video_renderer_impl.cc

+++ b/media/filters/video_renderer_impl.cc

@@ -92,8 +92,8 @@ void VideoRendererImpl::Flush(const base::Closure& callback) {

weak_factory_.GetWeakPtr()));

}

-void VideoRendererImpl::StartPlaying() {

- DVLOG(1) << __FUNCTION__;

+void VideoRendererImpl::StartPlayingFrom(base::TimeDelta timestamp) {

+ DVLOG(1) << __FUNCTION__ << "(" << timestamp.InMicroseconds() << ")";

DCHECK(task_runner_->BelongsToCurrentThread());

base::AutoLock auto_lock(lock_);

DCHECK_EQ(state_, kFlushed);

@@ -102,7 +102,7 @@ void VideoRendererImpl::StartPlaying() {

DCHECK_EQ(buffering_state_, BUFFERING_HAVE_NOTHING);

state_ = kPlaying;

- start_timestamp_ = get_time_cb_.Run();

+ start_timestamp_ = timestamp;

AttemptRead_Locked();

}