Switch back to using VideoRenderer::StartPlayingFrom().

media/filters/video_renderer_impl.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_FILTERS_VIDEO_RENDERER_IMPL_H_
 #define MEDIA_FILTERS_VIDEO_RENDERER_IMPL_H_
 
 #include <deque>
 
 #include "base/memory/ref_counted.h"
@@ skipping 50 matching lines @@
   // VideoRenderer implementation.
   virtual void Initialize(DemuxerStream* stream,
                           bool low_delay,
                           const PipelineStatusCB& init_cb,
                           const StatisticsCB& statistics_cb,
                           const BufferingStateCB& buffering_state_cb,
                           const base::Closure& ended_cb,
                           const PipelineStatusCB& error_cb,
                           const TimeDeltaCB& get_time_cb) OVERRIDE;
   virtual void Flush(const base::Closure& callback) OVERRIDE;
-  virtual void StartPlaying() OVERRIDE;
+  virtual void StartPlayingFrom(base::TimeDelta timestamp) OVERRIDE;
 
   // PlatformThread::Delegate implementation.
   virtual void ThreadMain() OVERRIDE;
 
  private:
   // Callback for |video_frame_stream_| initialization.
   void OnVideoFrameStreamInitialized(bool success);
 
   // Callback for |video_frame_stream_| to deliver decoded video frames and
   // report video decoding status.
@@ skipping 51 matching lines @@
   // rendering.
   bool received_end_of_stream_;
   bool rendered_end_of_stream_;
 
   // Used to signal |thread_| as frames are added to |frames_|.  Rule of thumb:
   // always check |state_| to see if it was set to STOPPED after waking up!
   base::ConditionVariable frame_available_;
 
   // Important detail: being in kPlaying doesn't imply that video is being
   // rendered. Rather, it means that the renderer is ready to go. The actual
   // rendering of video is controlled by time advancing via |time_cb_|.

[wolenetz, 2014/09/16 00:36:03]

nit: what is |time_cb_|? It seems this comment may have gotten out of sync with
code already. Is |get_time_cb_| meant here?

[scherkus (not reviewing), 2014/09/16 00:49:44]

fixed to use |get_time_cb_|

   //
   //   kUninitialized
   //         | Initialize()
   //         |
   //         V
   //    kInitializing
   //         | Decoders initialized
   //         |
   //         V            Decoders reset
   //      kFlushed <------------------ kFlushing
   //         | StartPlaying()             ^

[wolenetz, 2014/09/16 00:36:03]

nit: /g()/gFrom()/

[scherkus (not reviewing), 2014/09/16 00:49:44]

Done.

   //         |                            |
   //         |                            | Flush()
   //         `---------> kPlaying --------'
   enum State {
     kUninitialized,
     kInitializing,
     kFlushing,
     kFlushed,
     kPlaying
   };
@@ skipping 44 matching lines @@
 
   // NOTE: Weak pointers must be invalidated before all other member variables.
   base::WeakPtrFactory<VideoRendererImpl> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(VideoRendererImpl);
 };
 
 }  // namespace media
 
 #endif  // MEDIA_FILTERS_VIDEO_RENDERER_IMPL_H_