Implement MediaKeySession close() and remove()

Implement MediaKeySession close() and remove()

Rename existing release() method to close(), and add remove().

BUG=358271
TEST=updated EME tests pass

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183689

[jrummell, 2014-09-12 20:44:13]

jrummell@chromium.org changed reviewers:
+ ddorwin@chromium.org, sandersd@chromium.org

[jrummell, 2014-09-12 20:44:14]

PTAL.

[sandersd (OOO until July 31), 2014-09-17 00:33:22]

lgtm

[ddorwin, 2014-09-17 23:26:41]

I skimmed the CL. LGTM % comment.

https://codereview.chromium.org/568033003/diff/1/Source/modules/encryptedmedi...
File Source/modules/encryptedmedia/MediaKeySession.cpp (right):

https://codereview.chromium.org/568033003/diff/1/Source/modules/encryptedmedi...
Source/modules/encryptedmedia/MediaKeySession.cpp:227: ASSERT(sessionType ==
kTemporary || sessionType == kPersistent);
Future improvement: We should change m_sessionType to an enum, convert it here,
and pass that to Chromium.

https://codereview.chromium.org/568033003/diff/1/Source/modules/encryptedmedi...
Source/modules/encryptedmedia/MediaKeySession.cpp:443:
SimpleContentDecryptionModuleResult* result = new
SimpleContentDecryptionModuleResult(scriptState);
Is there a generic way to return a resolved promise at this point? We don't need
any of the fancy EME-specific stuff, right?

[jrummell, 2014-09-18 00:15:02]

jrummell@chromium.org changed reviewers:
+ wolenetz@chromium.org

[jrummell, 2014-09-18 00:15:03]

+wolenetz

https://codereview.chromium.org/568033003/diff/1/Source/modules/encryptedmedi...
File Source/modules/encryptedmedia/MediaKeySession.cpp (right):

https://codereview.chromium.org/568033003/diff/1/Source/modules/encryptedmedi...
Source/modules/encryptedmedia/MediaKeySession.cpp:227: ASSERT(sessionType ==
kTemporary || sessionType == kPersistent);
On 2014/09/17 23:26:41, ddorwin wrote:
> Future improvement: We should change m_sessionType to an enum, convert it
here,
> and pass that to Chromium.

Acknowledged.

https://codereview.chromium.org/568033003/diff/1/Source/modules/encryptedmedi...
Source/modules/encryptedmedia/MediaKeySession.cpp:443:
SimpleContentDecryptionModuleResult* result = new
SimpleContentDecryptionModuleResult(scriptState);
On 2014/09/17 23:26:41, ddorwin wrote:
> Is there a generic way to return a resolved promise at this point? We don't
need
> any of the fancy EME-specific stuff, right?

There is ScriptPromise::cast(), so changed to use it.

[ddorwin, 2014-09-18 00:33:02]

https://codereview.chromium.org/568033003/diff/20001/Source/modules/encrypted...
File Source/modules/encryptedmedia/MediaKeySession.cpp (right):

https://codereview.chromium.org/568033003/diff/20001/Source/modules/encrypted...
Source/modules/encryptedmedia/MediaKeySession.cpp:444: return
ScriptPromise::cast(scriptState, ScriptValue());
Hmm. I wonder why there isn't also a resolve() wrapper for cast. It sure looks
strange here, but the comments indicate that this is correct.

[jrummell, 2014-09-29 23:10:35]

jrummell@chromium.org changed reviewers:
+ abarth@chromium.org

[jrummell, 2014-09-29 23:10:35]

+abarth@ for OWNERS review of Source/platform and public/platform (2 files)

[wolenetz, 2014-10-02 00:36:40]

I'll do a first round of a noob-to-eme CR of this tomorrow.

[jrummell, 2014-10-13 18:01:58]

jrummell@chromium.org changed reviewers:
- abarth@chromium.org

[jrummell, 2014-10-14 01:13:38]

The CQ bit was checked by jrummell@chromium.org

[commit-bot: I haz the power, 2014-10-14 01:14:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/568033003/70001

[commit-bot: I haz the power, 2014-10-14 03:23:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-14 03:23:23]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/31606)

[jrummell, 2014-10-14 16:57:58]

The CQ bit was checked by jrummell@chromium.org

[commit-bot: I haz the power, 2014-10-14 16:58:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/568033003/70001

[commit-bot: I haz the power, 2014-10-14 18:17:45]

Committed patchset #4 (id:70001) as 183689