content/browser/service_worker/service_worker_job_unittest.cc - Issue 567903002: ServiceWorker: Change worker script fetch error code(2/3).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_job_unittest.cc

Issue 567903002: ServiceWorker: Change worker script fetch error code(2/3). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase & fix typo Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/browser/service_worker/service_worker_register_job.cc » ('j') | content/browser/service_worker/service_worker_register_job.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_job_unittest.cc

diff --git a/content/browser/service_worker/service_worker_job_unittest.cc b/content/browser/service_worker/service_worker_job_unittest.cc

index 8738415ae030bf7017260dea7075203962ecbf49..8c29e8d8453b446520f3b56df60943b5697e3b74 100644

--- a/content/browser/service_worker/service_worker_job_unittest.cc

+++ b/content/browser/service_worker/service_worker_job_unittest.cc

@@ -945,7 +945,8 @@ class UpdateJobTestHelper

int64 resource_id = storage()->NewResourceId();

version->script_cache_map()->NotifyStartedCaching(script, resource_id);

WriteStringResponse(storage(), resource_id, kMockScriptBody);

- version->script_cache_map()->NotifyFinishedCaching(script, true);

+ version->script_cache_map()->NotifyFinishedCaching(

+ script, net::URLRequestStatus());

} else {

// Spoof caching the script for the new version.

int64 resource_id = storage()->NewResourceId();

@@ -954,7 +955,8 @@ class UpdateJobTestHelper

WriteStringResponse(storage(), resource_id, kMockScriptBody);

else

WriteStringResponse(storage(), resource_id, "mock_different_script");

- version->script_cache_map()->NotifyFinishedCaching(script, true);

+ version->script_cache_map()->NotifyFinishedCaching(

+ script, net::URLRequestStatus());

}

EmbeddedWorkerTestHelper::OnStartWorker(

embedded_worker_id, version_id, scope, script, pause_after_download);