Fix logic for determing remote name from remote branch.

Fix logic for determing remote name from remote branch.

BUG=413391
R=iannucci@chromium.org,agable@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=292117

[szager1, 2014-09-23 23:25:16]

ping

[iannucci, 2014-09-24 08:55:00]

yay! lgtm.... sorry I missed this review earlier

https://codereview.chromium.org/567873002/diff/1/git_rebase_update.py
File git_rebase_update.py (right):

https://codereview.chromium.org/567873002/diff/1/git_rebase_update.py#newcode48
git_rebase_update.py:48: for fetchspec_config in
all_fetchspec_configs.splitlines():
there may be an extra newline at the end... I'd double check if it needs to be
stripped

https://codereview.chromium.org/567873002/diff/1/git_rebase_update.py#newcode50
git_rebase_update.py:50: dest_spec = fetchspec.partition(':')[2]
nit: imo split is clearer.

[szager1, 2014-09-24 17:23:11]

https://codereview.chromium.org/567873002/diff/1/git_rebase_update.py
File git_rebase_update.py (right):

https://codereview.chromium.org/567873002/diff/1/git_rebase_update.py#newcode48
git_rebase_update.py:48: for fetchspec_config in
all_fetchspec_configs.splitlines():
On 2014/09/24 08:55:00, iannucci wrote:
> there may be an extra newline at the end... I'd double check if it needs to be
> stripped

Done.

https://codereview.chromium.org/567873002/diff/1/git_rebase_update.py#newcode50
git_rebase_update.py:50: dest_spec = fetchspec.partition(':')[2]
On 2014/09/24 08:55:00, iannucci wrote:
> nit: imo split is clearer.

meh, the thing I like about partition is that it's like split(sep, 1), but I
don't have to remember the '1' argument.  And the result always has exactly
three elements, even if the separator isn't in the string, so it's always safe
to:

a, b, c = something.partition(sep)

[szager1, 2014-09-24 17:23:54]

The CQ bit was checked by szager@chromium.org

[commit-bot: I haz the power, 2014-09-24 17:24:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/567873002/20001

[commit-bot: I haz the power, 2014-09-24 17:25:48]

Committed patchset #2 (id:20001) as 292117