Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(699)

Issue 567853002: Cast: Make pacing controllable by the extension (Closed)

Created:
6 years, 3 months ago by hubbe
Modified:
6 years, 3 months ago
Reviewers:
Alpha Left Google
CC:
chromium-reviews, hclam+watch_chromium.org, cbentzel+watch_chromium.org, imcheng+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, pwestin+watch_google.com, feature-media-reviews_chromium.org, miu+watch_chromium.org, hubbe+watch_chromium.org, mikhal+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Cast: Make pacing controllable by the extension Use are brand-spanking-new options dictionary to be able to configure the target and max burst size for the pacer. This should allow us to do some basic experiments to determine if pacing is really helpful and what the optimal batch size actually is. Committed: https://crrev.com/1f663f57f1a2d04efcce4e4ee7f71711050d8824 Cr-Commit-Position: refs/heads/master@{#294657}

Patch Set 1 #

Total comments: 2

Patch Set 2 : comment added #

Patch Set 3 : forgot to fix test files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -23 lines) Patch
M media/cast/net/cast_transport_sender_impl.h View 1 1 chunk +7 lines, -0 lines 0 comments Download
M media/cast/net/cast_transport_sender_impl.cc View 2 chunks +21 lines, -1 line 0 comments Download
M media/cast/net/pacing/paced_sender.h View 3 chunks +10 lines, -1 line 0 comments Download
M media/cast/net/pacing/paced_sender.cc View 7 chunks +15 lines, -16 lines 0 comments Download
M media/cast/net/pacing/paced_sender_unittest.cc View 1 2 1 chunk +6 lines, -2 lines 0 comments Download
M media/cast/net/rtp/rtp_packetizer_unittest.cc View 1 2 1 chunk +6 lines, -2 lines 0 comments Download
M media/cast/receiver/cast_receiver_impl.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
hubbe
6 years, 3 months ago (2014-09-11 23:42:44 UTC) #2
Alpha Left Google
https://codereview.chromium.org/567853002/diff/1/media/cast/net/cast_transport_sender_impl.cc File media/cast/net/cast_transport_sender_impl.cc (right): https://codereview.chromium.org/567853002/diff/1/media/cast/net/cast_transport_sender_impl.cc#newcode75 media/cast/net/cast_transport_sender_impl.cc:75: pacer_(LookupOptionWithDefault(*options.get(), Please document in the header the list of ...
6 years, 3 months ago (2014-09-12 06:26:14 UTC) #3
hubbe
https://codereview.chromium.org/567853002/diff/1/media/cast/net/cast_transport_sender_impl.cc File media/cast/net/cast_transport_sender_impl.cc (right): https://codereview.chromium.org/567853002/diff/1/media/cast/net/cast_transport_sender_impl.cc#newcode75 media/cast/net/cast_transport_sender_impl.cc:75: pacer_(LookupOptionWithDefault(*options.get(), On 2014/09/12 06:26:14, Alpha wrote: > Please document ...
6 years, 3 months ago (2014-09-12 17:18:15 UTC) #4
Alpha Left Google
LGTM.
6 years, 3 months ago (2014-09-12 17:24:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/567853002/40001
6 years, 3 months ago (2014-09-12 19:59:50 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 4969d3ee5739548d119f8c7e7a9197a6b98ddf87
6 years, 3 months ago (2014-09-12 21:12:03 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 21:15:20 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1f663f57f1a2d04efcce4e4ee7f71711050d8824
Cr-Commit-Position: refs/heads/master@{#294657}

Powered by Google App Engine
This is Rietveld 408576698