Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 567743005: Moves ui/wm/public/window_types.h into aura.gyp/BUILD.gn (Closed)

Created:
6 years, 3 months ago by sky
Modified:
6 years, 2 months ago
CC:
chromium-reviews, sadrul, ben+aura_chromium.org, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Moves ui/wm/public/window_types.h into aura.gyp/BUILD.gn BUG=408650 TEST=none R=ben@chromium.org Committed: https://crrev.com/360b06ad8dcf4f8d6e3758fb50aa77e66b94798a Cr-Commit-Position: refs/heads/master@{#297081}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M ui/aura/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/aura/aura.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ui/wm/BUILD.gn View 2 chunks +0 lines, -4 lines 0 comments Download
M ui/wm/wm.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
sky
6 years, 3 months ago (2014-09-11 21:34:40 UTC) #1
Ben Goodger (Google)
lgtm
6 years, 3 months ago (2014-09-12 04:20:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/567743005/1
6 years, 3 months ago (2014-09-12 04:22:15 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_swarming/builds/8827)
6 years, 3 months ago (2014-09-12 05:27:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/567743005/1
6 years, 3 months ago (2014-09-12 19:59:45 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/13817) win_chromium_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/12117)
6 years, 3 months ago (2014-09-12 21:13:17 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/567743005/1
6 years, 2 months ago (2014-09-26 23:10:22 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1) as 71d9f5fb75d716e0eb3945ae4ef4590d02dfd82b
6 years, 2 months ago (2014-09-27 00:18:54 UTC) #13
commit-bot: I haz the power
6 years, 2 months ago (2014-09-27 00:19:35 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/360b06ad8dcf4f8d6e3758fb50aa77e66b94798a
Cr-Commit-Position: refs/heads/master@{#297081}

Powered by Google App Engine
This is Rietveld 408576698