Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 567713002: Mac: Fix profile button overlaps fullscreen button on new windows. (Closed)

Created:
6 years, 3 months ago by Andre
Modified:
6 years, 3 months ago
CC:
chromium-reviews, erikchen
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Mac: Fix profile button overlaps fullscreen button on new windows. This was recently broken by https://codereview.chromium.org/476313003/. The problem is that when opening a new window, the fullscreen button was not enabled yet by the time we layout the profile button. We need to call layoutSubviews after the fullscreen button is enabled because the avatar button's position depends on it. But with the old avatar button, we need to call layoutSubviews first because the fullscreen button's position depends on it. BUG=412018 Committed: https://crrev.com/b17510ab973cb1bebe259155b52ba65b2dc8c0fd Cr-Commit-Position: refs/heads/master@{#294450}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -6 lines) Patch
M chrome/browser/ui/cocoa/browser_window_controller.mm View 1 chunk +16 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Andre
rsesek@, noms@, please review.
6 years, 3 months ago (2014-09-11 17:55:42 UTC) #2
Robert Sesek
LGTM
6 years, 3 months ago (2014-09-11 18:40:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/567713002/1
6 years, 3 months ago (2014-09-11 18:44:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 906f2037cb7f3c04e88b59f460570d27a52c8d9e
6 years, 3 months ago (2014-09-11 20:02:37 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 20:06:38 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b17510ab973cb1bebe259155b52ba65b2dc8c0fd
Cr-Commit-Position: refs/heads/master@{#294450}

Powered by Google App Engine
This is Rietveld 408576698