Issue 567653002: Use ConstructFromLiteral instead of implicit conversion

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 567653002: Use ConstructFromLiteral instead of implicit conversion (Closed)

Created:
6 years, 3 months ago by rwlbuis

Modified:
6 years, 3 months ago

Reviewers:
pdr., kouhei (in TOK)

CC:
blink-reviews, krit, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, Stephen Chennney, kouhei+svg_chromium.org, pdr.

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Use ConstructFromLiteral instead of implicit conversion Since we are supposed to end up with an AtomicString, don't rely on implicit conversion, but provide it as static local variable while using ConstructFromLiteral to avoid using strlen. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181840