Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 567643003: easy-unlock: Only show "Set up" UI for en-US. (Closed)

Created:
6 years, 3 months ago by xiyuan
Modified:
6 years, 3 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

easy-unlock: Only show "Set up" UI for en-US. BUG=414467 Committed: https://crrev.com/78d93d0e19bbb635c4bfe6cb7dab0db26d04598c Cr-Commit-Position: refs/heads/master@{#295156}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/browser/resources/options/browser_options.js View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
xiyuan
6 years, 3 months ago (2014-09-16 20:44:40 UTC) #2
Ilya Sherman
LGTM
6 years, 3 months ago (2014-09-16 20:55:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/567643003/1
6 years, 3 months ago (2014-09-16 20:58:51 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 8459fe064bf878837f74bbbc800bfe5e6e60d000
6 years, 3 months ago (2014-09-16 22:05:49 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/78d93d0e19bbb635c4bfe6cb7dab0db26d04598c Cr-Commit-Position: refs/heads/master@{#295156}
6 years, 3 months ago (2014-09-16 22:06:41 UTC) #7
xiyuan
6 years, 3 months ago (2014-09-18 17:02:41 UTC) #8
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/580143002/ by xiyuan@chromium.org.

The reason for reverting is: en-US only is meant for M38. Revert to re-enable
setup for all locales..

Powered by Google App Engine
This is Rietveld 408576698