Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 567643002: Moving cleardata extension function. (Closed)

Created:
6 years, 3 months ago by lfg
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, Xi Han, wjmaclean
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Moving webview cleardata function. BUG=352293 Committed: https://crrev.com/b6eaeb96b8cbe6ee6146e9c2407a5b6620d47e93 Cr-Commit-Position: refs/heads/master@{#294420}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+219 lines, -214 lines) Patch
M chrome/browser/extensions/api/web_view/chrome_web_view_internal_api.h View 1 chunk +0 lines, -28 lines 0 comments Download
M chrome/browser/extensions/api/web_view/chrome_web_view_internal_api.cc View 3 chunks +0 lines, -108 lines 0 comments Download
M chrome/common/extensions/api/chrome_web_view_internal.json View 3 chunks +0 lines, -77 lines 0 comments Download
M chrome/renderer/resources/extensions/web_view.js View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/web_view/web_view_internal_api.h View 1 chunk +28 lines, -0 lines 0 comments Download
M extensions/browser/api/web_view/web_view_internal_api.cc View 3 chunks +111 lines, -0 lines 0 comments Download
M extensions/common/api/web_view_internal.json View 2 chunks +79 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
lfg
6 years, 3 months ago (2014-09-11 16:26:22 UTC) #2
Fady Samuel
lgtm
6 years, 3 months ago (2014-09-11 16:40:52 UTC) #3
lfg
6 years, 3 months ago (2014-09-11 16:50:11 UTC) #5
Fady Samuel
Btw, if we don't already have OWNERship of these files, perhaps we should take OWNERship? ...
6 years, 3 months ago (2014-09-11 16:53:52 UTC) #6
Ken Rockot(use gerrit already)
On 2014/09/11 16:53:52, Fady Samuel wrote: > Btw, if we don't already have OWNERship of ...
6 years, 3 months ago (2014-09-11 16:55:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/567643002/1
6 years, 3 months ago (2014-09-11 16:56:47 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as ab8feb0af391c92db907a5fdea91e58f36d0d12c
6 years, 3 months ago (2014-09-11 18:08:05 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 18:43:04 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b6eaeb96b8cbe6ee6146e9c2407a5b6620d47e93
Cr-Commit-Position: refs/heads/master@{#294420}

Powered by Google App Engine
This is Rietveld 408576698