Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issue 567563002: Move url_request_failed_job to net/test/url_request/ (Closed)

Created:
6 years, 3 months ago by xunjieli
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, cbentzel+watch_chromium.org, jam, mef
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move url_request_failed_job to net/test/url_request/ This CL is a second CL to move mock URLRequestJob files from content/test/net/ to net/test/url_request/. The first CL is crrev.com/541743002. The reason for this refactoring is that Cronet (go/cronet) will need to use url_request_failed_job and url_request_mock_http_job for testing. It will be nice if they can be in net/test, as Cronet wouldn't need to depend on content. BUG= Committed: https://crrev.com/2906f15fe42775f8f29599a0d799a5cc9f800188 Cr-Commit-Position: refs/heads/master@{#294499}

Patch Set 1 #

Patch Set 2 : fix compile error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -208 lines) Patch
M chrome/browser/captive_portal/captive_portal_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/errorpage_browsertest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/net/dns_probe_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/net/url_request_mock_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_browsertest.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
D content/test/net/url_request_failed_job.h View 1 chunk +0 lines, -64 lines 0 comments Download
D content/test/net/url_request_failed_job.cc View 1 chunk +0 lines, -110 lines 0 comments Download
M net/net.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
A + net/test/url_request/url_request_failed_job.h View 4 chunks +12 lines, -12 lines 0 comments Download
A + net/test/url_request/url_request_failed_job.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
xunjieli
+mmenke for net/ +avi for content/ +thestig for chrome/ Hi mmenke, avi and thesig, I ...
6 years, 3 months ago (2014-09-11 14:48:59 UTC) #2
Avi (use Gerrit)
content lgtm
6 years, 3 months ago (2014-09-11 14:52:56 UTC) #3
mmenke
On 2014/09/11 14:52:56, Avi wrote: > content lgtm LGTM. Helen: Just FYI, you didn't need ...
6 years, 3 months ago (2014-09-11 15:02:47 UTC) #4
Lei Zhang
lgtm
6 years, 3 months ago (2014-09-11 21:42:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/567563002/20001
6 years, 3 months ago (2014-09-11 22:24:15 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as d24d436a874559d786cf68c347e88e95d9040d1a
6 years, 3 months ago (2014-09-12 00:11:50 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 00:22:22 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2906f15fe42775f8f29599a0d799a5cc9f800188
Cr-Commit-Position: refs/heads/master@{#294499}

Powered by Google App Engine
This is Rietveld 408576698