Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1742)

Unified Diff: Source/platform/fonts/WidthIterator.h

Issue 567543002: Avoid re-parsing of string in fillText and measureText in Canvas (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Updating code and adding Layout test case Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/platform/fonts/WidthIterator.h
diff --git a/Source/platform/fonts/WidthIterator.h b/Source/platform/fonts/WidthIterator.h
index 490ebfabcf5ce87586ff7f1e16a47d81b98440c2..50bf2ef00265881946dc67c5c7ef7c20d54042e4 100644
--- a/Source/platform/fonts/WidthIterator.h
+++ b/Source/platform/fonts/WidthIterator.h
@@ -79,9 +79,9 @@ private:
int characterOffset;
};
- GlyphData glyphDataForCharacter(CharacterData&);
+ GlyphData glyphDataForCharacter(CharacterData&, bool spaceNormalize = false);
eae 2014/09/16 00:46:34 normalizeSpace
h.joshi 2014/09/16 05:48:11 Done.
float characterWidth(UChar32, const GlyphData&) const;
- void cacheFallbackFont(UChar32, const SimpleFontData*, const SimpleFontData* primaryFont);
+ void cacheFallbackFont(const SimpleFontData*, const SimpleFontData* primaryFont);
eae 2014/09/16 00:46:34 Why is the character param no longer needed here?
h.joshi 2014/09/16 05:48:11 "glyphDataAndPageForCharacter" method takes care o
float adjustSpacing(float, const CharacterData&, const SimpleFontData&, GlyphBuffer*);
void updateGlyphBounds(const GlyphData&, float width, bool firstCharacter);

Powered by Google App Engine
This is Rietveld 408576698