Source/platform/fonts/mac/FontComplexTextMac.cpp - Issue 567543002: Avoid re-parsing of string in fillText and measureText in Canvas

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/fonts/mac/FontComplexTextMac.cpp

Issue 567543002: Avoid re-parsing of string in fillText and measureText in Canvas (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Updating test expectation file Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/platform/fonts/mac/FontComplexTextMac.cpp

diff --git a/Source/platform/fonts/mac/FontComplexTextMac.cpp b/Source/platform/fonts/mac/FontComplexTextMac.cpp

index a11f6f93c9c82a3ee1e558bbc8c20d3cb8d236ed..d0dcac0af5b5fbab7f810c25c3db2502f6c0a89c 100644

--- a/Source/platform/fonts/mac/FontComplexTextMac.cpp

+++ b/Source/platform/fonts/mac/FontComplexTextMac.cpp

@@ -158,7 +158,7 @@ const SimpleFontData* Font::fontDataForCombiningCharacterSequence(const UChar* c

size_t baseCharacterLength = 0;

U16_NEXT(characters, baseCharacterLength, length, baseCharacter);

- GlyphData baseCharacterGlyphData = glyphDataForCharacter(baseCharacter, false, variant);

+ GlyphData baseCharacterGlyphData = glyphDataForCharacter(baseCharacter, false, false, variant);

if (!baseCharacterGlyphData.glyph)

return 0;

« no previous file with comments | « Source/platform/fonts/harfbuzz/HarfBuzzShaper.cpp ('k') | Source/platform/text/TextRun.h » ('j') | no next file with comments »