Source/platform/fonts/WidthIterator.h - Issue 567543002: Avoid re-parsing of string in fillText and measureText in Canvas

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/fonts/WidthIterator.h

Issue 567543002: Avoid re-parsing of string in fillText and measureText in Canvas (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Updating test expectation file Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/platform/fonts/WidthIterator.h

diff --git a/Source/platform/fonts/WidthIterator.h b/Source/platform/fonts/WidthIterator.h

index 490ebfabcf5ce87586ff7f1e16a47d81b98440c2..9291a93a8f146dbe59aff9ec1545763cbd59375b 100644

--- a/Source/platform/fonts/WidthIterator.h

+++ b/Source/platform/fonts/WidthIterator.h

@@ -79,9 +79,9 @@ private:

int characterOffset;

};

- GlyphData glyphDataForCharacter(CharacterData&);

+ GlyphData glyphDataForCharacter(CharacterData&, bool normalizeSpace = false);

float characterWidth(UChar32, const GlyphData&) const;

- void cacheFallbackFont(UChar32, const SimpleFontData*, const SimpleFontData* primaryFont);

+ void cacheFallbackFont(const SimpleFontData*, const SimpleFontData* primaryFont);

float adjustSpacing(float, const CharacterData&, const SimpleFontData&, GlyphBuffer*);

void updateGlyphBounds(const GlyphData&, float width, bool firstCharacter);

« no previous file with comments | « Source/platform/fonts/Font.cpp ('k') | Source/platform/fonts/WidthIterator.cpp » ('j') | no next file with comments »