Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1190)

Issue 567533002: Test flakiness fix for mouseover-mouseout (Closed)

Created:
6 years, 3 months ago by Paritosh Kumar
Modified:
6 years, 3 months ago
CC:
Mike West
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Test flakiness fix for mouseover-mouseout Since test output dumped as text it can't put space for boxes. So removed space from expectation file. BUG=305346 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182582

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -56 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/events/mouseover-mouseout-expected.txt View 1 2 chunks +1 line, -2 lines 0 comments Download
D LayoutTests/platform/linux-x86/fast/events/mouseover-mouseout-expected.txt View 1 chunk +0 lines, -52 lines 0 comments Download

Messages

Total messages: 31 (10 generated)
Paritosh Kumar
6 years, 3 months ago (2014-09-11 12:03:17 UTC) #1
Habib Virji
Looks good, can you add your name in authors file and push in new patch. ...
6 years, 3 months ago (2014-09-11 12:24:51 UTC) #3
Paritosh Kumar
https://codereview.chromium.org/567533002/diff/1/LayoutTests/fast/events/mouseover-mouseout-expected.txt File LayoutTests/fast/events/mouseover-mouseout-expected.txt (left): https://codereview.chromium.org/567533002/diff/1/LayoutTests/fast/events/mouseover-mouseout-expected.txt#oldcode53 LayoutTests/fast/events/mouseover-mouseout-expected.txt:53: On 2014/09/11 12:24:51, Habib Virji wrote: > Probably this ...
6 years, 3 months ago (2014-09-11 12:45:48 UTC) #4
Habib Virji
On 2014/09/11 12:45:48, Paritosh Kumar wrote: > https://codereview.chromium.org/567533002/diff/1/LayoutTests/fast/events/mouseover-mouseout-expected.txt > File LayoutTests/fast/events/mouseover-mouseout-expected.txt (left): > > https://codereview.chromium.org/567533002/diff/1/LayoutTests/fast/events/mouseover-mouseout-expected.txt#oldcode53 ...
6 years, 3 months ago (2014-09-18 09:35:07 UTC) #5
Paritosh Kumar
On 2014/09/18 09:35:07, Habib Virji wrote: > On 2014/09/11 12:45:48, Paritosh Kumar wrote: > > ...
6 years, 3 months ago (2014-09-18 11:03:52 UTC) #6
Paritosh Kumar
PTAL.
6 years, 3 months ago (2014-09-18 11:05:49 UTC) #8
Paritosh Kumar
PTAL.
6 years, 3 months ago (2014-09-19 09:21:47 UTC) #10
tyoshino (SeeGerritForStatus)
Took a look at https://bugs.webkit.org/show_bug.cgi?id=3439, https://bugs.webkit.org/show_bug.cgi?id=5764 and https://bugs.webkit.org/show_bug.cgi?id=7701. It seems appending a space to the ...
6 years, 3 months ago (2014-09-19 10:53:12 UTC) #13
Paritosh Kumar
On 2014/09/19 10:53:12, tyoshino wrote: > Took a look at https://bugs.webkit.org/show_bug.cgi?id=3439, > https://bugs.webkit.org/show_bug.cgi?id=5764 and > ...
6 years, 3 months ago (2014-09-19 12:27:01 UTC) #14
Paritosh Kumar
On 2014/09/19 10:53:12, tyoshino wrote: > Took a look at https://bugs.webkit.org/show_bug.cgi?id=3439, > https://bugs.webkit.org/show_bug.cgi?id=5764 and > ...
6 years, 3 months ago (2014-09-19 12:29:55 UTC) #15
Paritosh Kumar
6 years, 3 months ago (2014-09-21 13:27:49 UTC) #17
Paritosh Kumar
PTAL.
6 years, 3 months ago (2014-09-22 10:58:51 UTC) #19
Paritosh Kumar
PTAL.
6 years, 3 months ago (2014-09-23 11:16:38 UTC) #20
Takashi Toyoshima
Hi, can you clarify more details about backgrounds? I can not understand why this is ...
6 years, 3 months ago (2014-09-23 13:20:46 UTC) #21
Paritosh Kumar
Thanks. > Hi, can you clarify more details about backgrounds? Since the test output is ...
6 years, 3 months ago (2014-09-23 14:38:10 UTC) #22
Takashi Toyoshima
Aha, the test was introduced by an Apple guy when the project was WebKit. Darin ...
6 years, 3 months ago (2014-09-24 04:43:23 UTC) #23
tyoshino (SeeGerritForStatus)
On 2014/09/24 04:43:23, Takashi Toyoshima (chromium) wrote: > Aha, the test was introduced by an ...
6 years, 3 months ago (2014-09-24 09:33:35 UTC) #24
Paritosh Kumar
6 years, 3 months ago (2014-09-24 09:36:32 UTC) #26
Mike West
This fix LGTM.
6 years, 3 months ago (2014-09-24 09:36:47 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/567533002/20001
6 years, 3 months ago (2014-09-24 09:38:17 UTC) #30
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 10:42:40 UTC) #31
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 182582

Powered by Google App Engine
This is Rietveld 408576698