Test flakiness fix for mouseover-mouseout

Test flakiness fix for mouseover-mouseout

Since test output dumped as text it can't put space for boxes.
So removed space from expectation file.

BUG=305346
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182582

[Habib Virji, 2014-09-11 12:24:50]

habib.virji@samsung.com changed reviewers:
+ habib.virji@samsung.com

[Habib Virji, 2014-09-11 12:24:51]

Looks good, can you add your name in authors file and push in new patch.

https://codereview.chromium.org/567533002/diff/1/LayoutTests/fast/events/mous...
File LayoutTests/fast/events/mouseover-mouseout-expected.txt (left):

https://codereview.chromium.org/567533002/diff/1/LayoutTests/fast/events/mous...
LayoutTests/fast/events/mouseover-mouseout-expected.txt:53: 
Probably this line should be there. Please check and add back this line.

[Paritosh Kumar, 2014-09-11 12:45:48]

https://codereview.chromium.org/567533002/diff/1/LayoutTests/fast/events/mous...
File LayoutTests/fast/events/mouseover-mouseout-expected.txt (left):

https://codereview.chromium.org/567533002/diff/1/LayoutTests/fast/events/mous...
LayoutTests/fast/events/mouseover-mouseout-expected.txt:53: 
On 2014/09/11 12:24:51, Habib Virji wrote:
> Probably this line should be there. Please check and add back this line.

Since there is no any element after success it will not apear in dump text.
Thanks.

[Habib Virji, 2014-09-18 09:35:07]

On 2014/09/11 12:45:48, Paritosh Kumar wrote:
>
https://codereview.chromium.org/567533002/diff/1/LayoutTests/fast/events/mous...
> File LayoutTests/fast/events/mouseover-mouseout-expected.txt (left):
> 
>
https://codereview.chromium.org/567533002/diff/1/LayoutTests/fast/events/mous...
> LayoutTests/fast/events/mouseover-mouseout-expected.txt:53: 
> On 2014/09/11 12:24:51, Habib Virji wrote:
> > Probably this line should be there. Please check and add back this line.
> 
> Since there is no any element after success it will not apear in dump text.
> Thanks.

Can you please add a reviewer to this issue and remove WIP.

[Paritosh Kumar, 2014-09-18 11:03:52]

On 2014/09/18 09:35:07, Habib Virji wrote:
> On 2014/09/11 12:45:48, Paritosh Kumar wrote:
> >
>
https://codereview.chromium.org/567533002/diff/1/LayoutTests/fast/events/mous...
> > File LayoutTests/fast/events/mouseover-mouseout-expected.txt (left):
> > 
> >
>
https://codereview.chromium.org/567533002/diff/1/LayoutTests/fast/events/mous...
> > LayoutTests/fast/events/mouseover-mouseout-expected.txt:53: 
> > On 2014/09/11 12:24:51, Habib Virji wrote:
> > > Probably this line should be there. Please check and add back this line.
> > 
> > Since there is no any element after success it will not apear in dump text.
> > Thanks.
> 
> Can you please add a reviewer to this issue and remove WIP.

Thanks.

[Paritosh Kumar, 2014-09-18 11:05:48]

paritosh.in@samsung.com changed reviewers:
+ tyoshino@chromium.org

[Paritosh Kumar, 2014-09-18 11:05:49]

PTAL.

[Paritosh Kumar, 2014-09-19 09:21:47]

paritosh.in@samsung.com changed reviewers:
+ darin@chromium.org
- habib.virji@samsung.com

[Paritosh Kumar, 2014-09-19 09:21:47]

PTAL.

[Paritosh Kumar, 2014-09-19 09:58:09]

The CQ bit was checked by paritosh.in@samsung.com

[Paritosh Kumar, 2014-09-19 09:58:12]

The CQ bit was unchecked by paritosh.in@samsung.com

[tyoshino (SeeGerritForStatus), 2014-09-19 10:53:12]

Took a look at https://bugs.webkit.org/show_bug.cgi?id=3439,
https://bugs.webkit.org/show_bug.cgi?id=5764 and
https://bugs.webkit.org/show_bug.cgi?id=7701. It seems appending a space to the
inner text contents "1, 2, ..." in the divs doesn't affect what's tested by the
layout tests.

But I'm not familiar with mouse event handling. Please get it reviewed by
someone working on the mouse event handling code. Especially the code edited by
this commit
https://chromium.googlesource.com/chromium/blink/+/7d8695d772513026eb99d3c263....
It's currently placed in Source/core/page/EventHandler.cpp.

If you don't make any change on the layout test file but replace the main
expectation file with the platform-specific expectation file you're deleting,
then I can l-g-t-m.

[Paritosh Kumar, 2014-09-19 12:27:01]

On 2014/09/19 10:53:12, tyoshino wrote:
> Took a look at https://bugs.webkit.org/show_bug.cgi?id=3439,
> https://bugs.webkit.org/show_bug.cgi?id=5764 and
> https://bugs.webkit.org/show_bug.cgi?id=7701. It seems appending a space to
the
> inner text contents "1, 2, ..." in the divs doesn't affect what's tested by
the
> layout tests.
> 
> But I'm not familiar with mouse event handling. Please get it reviewed by
> someone working on the mouse event handling code. Especially the code edited
by
> this commit
>
https://chromium.googlesource.com/chromium/blink/+/7d8695d772513026eb99d3c263....
> It's currently placed in Source/core/page/EventHandler.cpp.
> 
> If you don't make any change on the layout test file but replace the main
> expectation file with the platform-specific expectation file you're deleting,
> then I can l-g-t-m.

Thanks. Yes, appending space doesn't affect what's tested by layout test.
Updated as suggested.

[Paritosh Kumar, 2014-09-19 12:29:55]

On 2014/09/19 10:53:12, tyoshino wrote:
> Took a look at https://bugs.webkit.org/show_bug.cgi?id=3439,
> https://bugs.webkit.org/show_bug.cgi?id=5764 and
> https://bugs.webkit.org/show_bug.cgi?id=7701. It seems appending a space to
the
> inner text contents "1, 2, ..." in the divs doesn't affect what's tested by
the
> layout tests.
> 
> But I'm not familiar with mouse event handling. Please get it reviewed by
> someone working on the mouse event handling code. Especially the code edited
by
> this commit
>
https://chromium.googlesource.com/chromium/blink/+/7d8695d772513026eb99d3c263....
> It's currently placed in Source/core/page/EventHandler.cpp.
> 
> If you don't make any change on the layout test file but replace the main
> expectation file with the platform-specific expectation file you're deleting,
> then I can l-g-t-m.

Thanks. Yes, appending space doesn't affect what's tested by layout test.
Updated as suggested.
PTAL.

[Paritosh Kumar, 2014-09-21 13:27:48]

paritosh.in@samsung.com changed reviewers:
- tyoshino@chromium.org

[Paritosh Kumar, 2014-09-22 10:58:51]

paritosh.in@samsung.com changed reviewers:
+ toyoshim@chromium.org

[Paritosh Kumar, 2014-09-22 10:58:51]

PTAL.

[Paritosh Kumar, 2014-09-23 11:16:38]

PTAL.

[Takashi Toyoshima, 2014-09-23 13:20:46]

Hi, can you clarify more details about backgrounds?
I can not understand why this is a correct update of the expectations from your
CL description and changes.

Also, I'm not familiar with this area. That means you need to explain more
details about this change for reviews.
Did you check who wrote this test originally? It would be better to involve the
original author if he still works on Chromium.

[Paritosh Kumar, 2014-09-23 14:38:10]

Thanks. 


> Hi, can you clarify more details about backgrounds?

Since the test output is taken in text format so the space for box 2, 3, 4 and 5
will not apear in the output.
And this test is related to mouseover and mouseout event, for that output is
correct.


> Did you check who wrote this test originally? It would be better to involve
the
> original author if he still works on Chromium.

I checked the reviewer for this file and found darin reviewed it in 2006. 
https://chromium.googlesource.com/chromium/blink/+/7d8695d772513026eb99d3c263...
This is the link of review.

And I added him also in reviewers list.

[Takashi Toyoshima, 2014-09-24 04:43:23]

Aha, the test was introduced by an Apple guy when the project was WebKit. Darin
is now a project top level owner, so it's difficult to get reviewed by him.

I checked the flakiness dashboad. The test is not flaky, but failing for a long
time. As far as I checked the test, the first line of dumpAsText() is not
essential for this test. So this change looks reasonable.

LGTM.

Add mkwst@ to CC just in case. I found that he wrote code for mouse event to
EventHandler.cpp one year ago according to a result of git annotate.

[tyoshino (SeeGerritForStatus), 2014-09-24 09:33:35]

On 2014/09/24 04:43:23, Takashi Toyoshima (chromium) wrote:
> Aha, the test was introduced by an Apple guy when the project was WebKit.
Darin
> is now a project top level owner, so it's difficult to get reviewed by him.

The reviewer of the CL is Darin Adler of Apple. Not darin@chromium.org, Darin
Fisher of Google.

[Paritosh Kumar, 2014-09-24 09:36:31]

paritosh.in@samsung.com changed reviewers:
- darin@chromium.org

[Mike West, 2014-09-24 09:36:46]

mkwst@chromium.org changed reviewers:
+ mkwst@chromium.org

[Mike West, 2014-09-24 09:36:47]

This fix LGTM.

[Paritosh Kumar, 2014-09-24 09:37:37]

The CQ bit was checked by paritosh.in@samsung.com

[commit-bot: I haz the power, 2014-09-24 09:38:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/567533002/20001

[commit-bot: I haz the power, 2014-09-24 10:42:40]

Committed patchset #2 (id:20001) as 182582