Source/bindings/tests/results/core/V8TestInterface2.cpp - Issue 567503002: Add toDouble() helper, and use toFloat()/toDouble() for conversions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/core/V8TestInterface2.cpp

Issue 567503002: Add toDouble() helper, and use toFloat()/toDouble() for conversions (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/templates/interface.cpp ('K') | « Source/bindings/tests/results/core/V8TestInterface.cpp ('k') | Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/core/V8TestInterface2.cpp

diff --git a/Source/bindings/tests/results/core/V8TestInterface2.cpp b/Source/bindings/tests/results/core/V8TestInterface2.cpp

index f2cbb124df60ade87d3bd40d4dc1d7882d4861a0..7383701c1f9d4969d75b9a1199e197c4342825e3 100644

--- a/Source/bindings/tests/results/core/V8TestInterface2.cpp

+++ b/Source/bindings/tests/results/core/V8TestInterface2.cpp

@@ -331,11 +331,11 @@ static void namedPropertySetter(v8::Local<v8::String> name, v8::Local<v8::Value>

if (!info.Holder()->GetRealNamedPropertyInPrototypeChain(name).IsEmpty())

return;

+ v8::String::Utf8Value namedProperty(name);

+ ExceptionState exceptionState(ExceptionState::SetterContext, *namedProperty, "TestInterface2", info.Holder(), info.GetIsolate());

TestInterface2* impl = V8TestInterface2::toImpl(info.Holder());

TOSTRING_VOID(V8StringResource<>, propertyName, name);

TOSTRING_VOID(V8StringResource<>, propertyValue, v8Value);

- v8::String::Utf8Value namedProperty(name);

- ExceptionState exceptionState(ExceptionState::SetterContext, *namedProperty, "TestInterface2", info.Holder(), info.GetIsolate());

bool result = impl->setNamedItem(propertyName, propertyValue, exceptionState);

if (exceptionState.throwIfNeeded())

return;