Move adjustForUnsplittableChild() from RenderBlock to RenderBlockFlow.

Move adjustForUnsplittableChild() from RenderBlock to RenderBlockFlow.

BUG=302024
R=leviw@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182757

[rune, 2014-09-25 11:13:22]

rune@opera.com changed reviewers:
+ rune@opera.com

[rune, 2014-09-25 11:13:23]

https://codereview.chromium.org/567463004/diff/1/Source/core/rendering/Render...
File Source/core/rendering/RenderBlockFlow.h (right):

https://codereview.chromium.org/567463004/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderBlockFlow.h:447: LayoutUnit
adjustForUnsplittableChild(RenderBox*, LayoutUnit logicalOffset, bool
includeMargins = false);
Adjust what? I know you didn't invent this method name, but either the method
name or the logicalOffset argument should be named to make it clear this is a
vertical offset. logicalTopOffset, if that's what it is.

[mstensho (USE GERRIT), 2014-09-26 11:09:01]

https://codereview.chromium.org/567463004/diff/1/Source/core/rendering/Render...
File Source/core/rendering/RenderBlockFlow.h (right):

https://codereview.chromium.org/567463004/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderBlockFlow.h:447: LayoutUnit
adjustForUnsplittableChild(RenderBox*, LayoutUnit logicalOffset, bool
includeMargins = false);
On 2014/09/25 11:13:22, rune wrote:
> Adjust what? I know you didn't invent this method name, but either the method
> name or the logicalOffset argument should be named to make it clear this is a
> vertical offset. logicalTopOffset, if that's what it is.

adjustPositionForUnsplittableChild()?
adjustUnsplittableChildPosition()?
adjustUnsplittableChildPositionForPagination()?
adjustUnsplittableChildForPagination()?
adjustUnsplittableBlockChildForPagination()?

My last suggestion here harmonizes well with the already existing
adjustBlockChildForPagination() method, FWIW.

Could rename the parameter to logicalTop too.

[rune, 2014-09-26 11:22:45]

LGTM.

Spoke with mstensho@ off-line. Moving the method without renaming it first,
makes sense. I'll happily accept a renaming in a separate commit, though :-)

[mstensho (USE GERRIT), 2014-09-26 11:24:10]

The CQ bit was checked by mstensho@opera.com

[commit-bot: I haz the power, 2014-09-26 11:24:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/567463004/1

[commit-bot: I haz the power, 2014-09-26 12:30:01]

Committed patchset #1 (id:1) as 182757