Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 567453002: Web SQL: Make sure DatabaseManager is used only in the main thread. (Closed)

Created:
6 years, 3 months ago by tkent
Modified:
6 years, 3 months ago
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Web SQL: Make sure DatabaseManager is used only in the main thread. Only DatabaseManager::closeDatabasesImmediately could be called in non-main threads. However, it just calls DatabaseTracker::closeDatabasesImmediately(). This CL removes DatabaseManager::closeDatabasesImmediately, and only the main thread uses DatabaseManager. So, we can remove DatabaseManager::m_contextMapLock. We still need m_contextMap because the main thread can have multiple Documents. Oilpan: We can use PersistentHeapHashMap, and remove some |#if ENABLE(OILPAN)|. BUG=347902, 397429 TEST=No new tests because of no behavior changes. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181810

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -51 lines) Patch
M Source/modules/webdatabase/AbstractDatabaseServer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/modules/webdatabase/DatabaseManager.h View 4 chunks +2 lines, -18 lines 0 comments Download
M Source/modules/webdatabase/DatabaseManager.cpp View 6 chunks +3 lines, -22 lines 0 comments Download
M Source/modules/webdatabase/DatabaseServer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/modules/webdatabase/DatabaseServer.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/web/WebDatabase.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
tkent
Please review this.
6 years, 3 months ago (2014-09-11 06:32:00 UTC) #2
Mads Ager (chromium)
LGTM
6 years, 3 months ago (2014-09-11 06:40:15 UTC) #4
haraken
LGTM!
6 years, 3 months ago (2014-09-11 06:56:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/567453002/1
6 years, 3 months ago (2014-09-11 07:56:13 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 10:23:29 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181810

Powered by Google App Engine
This is Rietveld 408576698