Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 567443003: Revert of Roll Clang 214024:216630 (+216684) and switch to CMake (Closed)

Created:
6 years, 3 months ago by hans
Modified:
6 years, 3 months ago
Reviewers:
Nico, eugenis, samsonov
CC:
chromium-reviews, eugenis+clang_chromium.org, glider+clang_chromium.org, dmikurube+clang_chromium.org, ukai+watch_chromium.org, zerny-chromium, dcheng, Ryan Sleevi, Elliot Glaysher
Project:
chromium
Visibility:
Public.

Description

Revert of Roll Clang 214024:216630 (+216684) and switch to CMake (patchset #20 id:380001 of https://codereview.chromium.org/453513004/) Reason for revert: Builds failing with: ../../third_party/skia/include/core/SkRect.h:280:25: error: reference cannot be bound to dereferenced null pointer in well-defined C++ code; pointer may be assumed to always convert to true [-Werror,-Wundefined-bool-conversion] SkASSERT(&a && &b); ~~ ^ ../../third_party/skia/include/core/SkTypes.h:96:56: note: expanded from macro 'SkASSERT' #define SkASSERT(cond) SK_ALWAYSBREAK(cond) ^ ../../third_party/skia/include/core/SkPostConfig.h:173:19: note: expanded from macro 'SK_ALWAYSBREAK' if (cond) break; \ ^ (From http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20%28dbg%29/builds/12335/steps/compile/logs/stdio) Original issue's description: > Roll Clang 214024:216630 (+216684) and switch to CMake > > This updates Chromium's clang version to r216630 with > r216684 cherry-picked to fix an ASan issue. > > It also changes the build script for Clang to use CMake > instead of Autoconf. The ASan team say this configuration > is better tested, and it also makes us consistent with > the Windows Clang build which already uses CMake. > > BUG=400849 > R=thakis@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/ff31c1ba254ca37f7a8b45549e1b7b1c978b3390 TBR=thakis@chromium.org,samsonov@google.com,eugenis@chromium.org NOTREECHECKS=true NOTRY=true BUG=400849 Committed: https://crrev.com/26d4304297fca3034d5fe01e0f56ea7b31301648 Cr-Commit-Position: refs/heads/master@{#294960}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -342 lines) Patch
M tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp View 3 chunks +5 lines, -6 lines 0 comments Download
D tools/clang/blink_gc_plugin/CMakeLists.txt View 1 chunk +0 lines, -35 lines 0 comments Download
A tools/clang/blink_gc_plugin/Makefile View 1 chunk +21 lines, -0 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/test.sh View 3 chunks +14 lines, -17 lines 0 comments Download
D tools/clang/plugins/CMakeLists.txt View 1 chunk +0 lines, -32 lines 0 comments Download
M tools/clang/plugins/FindBadConstructsAction.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/clang/plugins/FindBadConstructsAction.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A tools/clang/plugins/Makefile View 1 chunk +19 lines, -0 lines 0 comments Download
M tools/clang/plugins/tests/test.sh View 3 chunks +13 lines, -17 lines 0 comments Download
M tools/clang/scripts/blink_gc_plugin_flags.sh View 1 chunk +3 lines, -2 lines 0 comments Download
M tools/clang/scripts/package.sh View 6 chunks +10 lines, -18 lines 0 comments Download
M tools/clang/scripts/repackage.sh View 2 chunks +4 lines, -4 lines 0 comments Download
M tools/clang/scripts/update.sh View 13 chunks +91 lines, -208 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
hans
Created Revert of Roll Clang 214024:216630 (+216684) and switch to CMake
6 years, 3 months ago (2014-09-16 01:21:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/567443003/1
6 years, 3 months ago (2014-09-16 01:22:23 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 8e82aba49dd740b225ecd3a889c7f1811a8d0888
6 years, 3 months ago (2014-09-16 01:26:16 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 01:28:28 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/26d4304297fca3034d5fe01e0f56ea7b31301648
Cr-Commit-Position: refs/heads/master@{#294960}

Powered by Google App Engine
This is Rietveld 408576698