Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 567433002: Eliminate Turbofan shims with CodeFactory (Closed)

Created:
6 years, 3 months ago by mvstanton
Modified:
6 years, 3 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev, Yang
Project:
v8
Visibility:
Public.

Description

Turbofan needs a code handle and a CallInterfaceDescriptor. At the same time we spread knowledge about how to create the initial IC code object too widely. Consolidate code creation and unify it with a descriptor via CodeFactory. R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23877

Patch Set 1 #

Patch Set 2 : Use the factory as much as possible. #

Patch Set 3 : Ports. #

Total comments: 6

Patch Set 4 : Addressed comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+333 lines, -272 lines) Patch
M BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 1 2 11 chunks +18 lines, -19 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 2 8 chunks +11 lines, -10 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 2 11 chunks +19 lines, -19 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 1 2 8 chunks +11 lines, -10 lines 0 comments Download
M src/assembler.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
A src/code-factory.h View 1 2 3 1 chunk +61 lines, -0 lines 0 comments Download
A src/code-factory.cc View 1 2 3 1 chunk +92 lines, -0 lines 0 comments Download
M src/compiler/js-generic-lowering.h View 1 2 3 3 chunks +2 lines, -5 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 2 3 9 chunks +40 lines, -136 lines 0 comments Download
M src/compiler/raw-machine-assembler.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 2 chunks +6 lines, -4 lines 0 comments Download
M src/full-codegen.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 2 11 chunks +18 lines, -19 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 2 8 chunks +11 lines, -10 lines 0 comments Download
M src/x64/builtins-x64.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 2 11 chunks +18 lines, -19 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 2 8 chunks +11 lines, -10 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
mvstanton
Hi Michael, Here is the change we talked about, PTAL, thanks! --Michael
6 years, 3 months ago (2014-09-11 11:56:31 UTC) #3
Michael Starzinger
LGTM with a couple of nits. Note that I only reviewed one of the architecture ...
6 years, 3 months ago (2014-09-11 12:26:54 UTC) #4
mvstanton
6 years, 3 months ago (2014-09-11 13:19:20 UTC) #5
Message was sent while issue was closed. 
Committed patchset #4 (id:80001) manually as 23877 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698