Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 567413003: Revert of Remove deprecated cursor event filter for Ozone (Closed)

Created:
6 years, 3 months ago by acolwell GONE FROM CHROMIUM
Modified:
6 years, 3 months ago
Reviewers:
dnicoara, oshima
CC:
chromium-reviews, kalyank, sadrul, ozone-reviews_chromium.org, ben+ash_chromium.org, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove deprecated cursor event filter for Ozone (patchset #2 id:20001 of https://codereview.chromium.org/580553002/) Reason for revert: This appears to be causing ImmersiveFullscreenControllerTest.MouseEventsVerticalDisplayLayout to fail on Chromium OS Ozone bots. http://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=Linux%20ChromiumOS%20Ozone%20Tests%20%281%29&number=3404 http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Tests%20%281%29/builds/3405 Original issue's description: > Remove deprecated cursor event filter for Ozone > > Removes the old filter in favor of the new one which is enabled > by default on non-Ozone CrOS builds. > > BUG=none > TESTS=ran ash_unittests --gtest_filter=MouseCursorEventFilterTest.* on an Ozone build and manually tested on link_freon > > Committed: https://crrev.com/cee48a5ba8c24eb8b8ea7f789e3025ac79549a4d > Cr-Commit-Position: refs/heads/master@{#295169} TBR=oshima@chromium.org,dnicoara@chromium.org NOTREECHECKS=true NOTRY=true BUG=none Committed: https://crrev.com/fedbb0d1fd040adf809f3068e601d2963321bd47 Cr-Commit-Position: refs/heads/master@{#295178}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+206 lines, -2 lines) Patch
M ash/BUILD.gn View 1 chunk +6 lines, -0 lines 0 comments Download
M ash/ash.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ash/display/mouse_cursor_event_filter.h View 1 chunk +6 lines, -0 lines 0 comments Download
M ash/display/mouse_cursor_event_filter.cc View 6 chunks +6 lines, -0 lines 0 comments Download
A ash/display/mouse_cursor_event_filter_ozone.cc View 1 chunk +107 lines, -0 lines 0 comments Download
M ash/display/mouse_cursor_event_filter_unittest.cc View 2 chunks +79 lines, -0 lines 0 comments Download
M ui/ozone/platform/dri/dri_cursor.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
acolwell GONE FROM CHROMIUM
Created Revert of Remove deprecated cursor event filter for Ozone
6 years, 3 months ago (2014-09-16 23:46:27 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/567413003/1
6 years, 3 months ago (2014-09-16 23:47:34 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as a4e1108a81b0918424d8367ef706853023ec89e3
6 years, 3 months ago (2014-09-16 23:49:18 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 23:49:53 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fedbb0d1fd040adf809f3068e601d2963321bd47
Cr-Commit-Position: refs/heads/master@{#295178}

Powered by Google App Engine
This is Rietveld 408576698