Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 567403004: MSE: Test no muxed discontinuity forced by audio frame partial front trimming (Closed)

Created:
6 years, 3 months ago by wolenetz
Modified:
6 years, 3 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

MSE: Test no muxed discontinuity forced by audio frame partial front trimming This change adds frame processor tests to cover the behavior recently landed from bad1c509 that changed "segments" appendMode's partial front trimming logic. BUG=408216 R=dalecurtis@chromium.org TEST=new segments test fails before and passes after bad1c509, new sequence test passes before and after Committed: https://crrev.com/772b33525c1dfbe3c1fd0ea06fd1944a40ad7ffb Cr-Commit-Position: refs/heads/master@{#294920}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M media/filters/frame_processor_unittest.cc View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
wolenetz
PTAL
6 years, 3 months ago (2014-09-15 21:21:53 UTC) #1
DaleCurtis
lgtm
6 years, 3 months ago (2014-09-15 21:37:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/567403004/1
6 years, 3 months ago (2014-09-15 22:04:01 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as bf05bb8682cc7f040700fa6c1746f332af65a31b
6 years, 3 months ago (2014-09-15 23:31:46 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-15 23:34:24 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/772b33525c1dfbe3c1fd0ea06fd1944a40ad7ffb
Cr-Commit-Position: refs/heads/master@{#294920}

Powered by Google App Engine
This is Rietveld 408576698