Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Issue 567403002: Log SPDY protocol specific setting IDs (alternate). (Closed)

Created:
6 years, 3 months ago by Bence
Modified:
6 years, 3 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Log SPDY protocol specific setting IDs (alternate). This is an alternate way of achieving the same as https://crrev.com/568093002. In this version, instead of calling ToEventParametersCallback to get a callable, then passing it around, then calling it, the body of SourceEventParametersCallback is duplicated in NetLogSpdyInitializedCallback. This yields faster, simpler, more direct code, at the expense of code duplication. Only one of this CL and https://crrev.com/568093002 should be committed. BUG=413369 Committed: https://crrev.com/382003433672bca0ac734299c91dfe14ec167f05 Cr-Commit-Position: refs/heads/master@{#295059}

Patch Set 1 #

Patch Set 2 : Nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -14 lines) Patch
M net/spdy/spdy_session.cc View 1 7 chunks +38 lines, -14 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Bence
PTAL
6 years, 3 months ago (2014-09-15 14:40:39 UTC) #2
Ryan Hamilton
lgtm
6 years, 3 months ago (2014-09-15 21:41:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/567403002/20001
6 years, 3 months ago (2014-09-16 13:00:19 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 827fc0395e9e9b330f2153ca7ba7953a7a83a683
6 years, 3 months ago (2014-09-16 14:09:05 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 14:10:43 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/382003433672bca0ac734299c91dfe14ec167f05
Cr-Commit-Position: refs/heads/master@{#295059}

Powered by Google App Engine
This is Rietveld 408576698