Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(883)

Unified Diff: chrome/browser/chromeos/policy/device_cloud_policy_invalidator.h

Issue 567393006: Do not use unaffiliated users' connections for device policy pushing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Re-add a check accidentally removed in the previous patch. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/policy/device_cloud_policy_invalidator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/policy/device_cloud_policy_invalidator.h
diff --git a/chrome/browser/chromeos/policy/device_cloud_policy_invalidator.h b/chrome/browser/chromeos/policy/device_cloud_policy_invalidator.h
index 4ab0d45984c5b28b6bc44ed40fe145b1d3e5322d..875719f52ab3ef692ec6c5850983a01f95d413b2 100644
--- a/chrome/browser/chromeos/policy/device_cloud_policy_invalidator.h
+++ b/chrome/browser/chromeos/policy/device_cloud_policy_invalidator.h
@@ -23,12 +23,11 @@ namespace policy {
class CloudPolicyInvalidator;
// This class provides invalidations for device policy via a
-// |CloudPolicyInvalidator| backed by an |InvalidationService|. If a user with a
-// connected invalidation service is logged in, that service is used to conserve
-// server resources. If there are no logged-in users or none of them have
-// connected invalidation services, a device-global |TiclInvalidationService| is
-// spun up.
-// The class monitors the status of all invalidation services and switches
+// |CloudPolicyInvalidator| backed by an |InvalidationService|. If an affiliated
+// user with a connected invalidation service is logged in, that service is used
+// to conserve server resources. If there are no logged-in users matching these
+// criteria, a device-global |TiclInvalidationService| is spun up.
+// The class monitors the status of the invalidation services and switches
// between them whenever the service currently in use disconnects or the
// device-global invalidation service can be replaced with another service that
// just connected.
@@ -55,11 +54,11 @@ class DeviceCloudPolicyInvalidator : public content::NotificationObserver {
invalidation::InvalidationService* invalidation_service);
// Attempt to create a |CloudPolicyInvalidator| backed by a connected
- // invalidation service. If there is no connected invalidation service, a
- // |CloudPolicyInvalidator| will be created later when a connected service
- // becomes available.
+ // invalidation service. If no connected invalidation service is available for
+ // use, a |CloudPolicyInvalidator| will be created later when a connected
+ // service becomes available.
// Further ensures that a device-global invalidation service is running iff
- // there is no other connected service.
+ // there is no other connected service available for use.
void TryToCreateInvalidator();
// Create a |CloudPolicyInvalidator| backed by the |invalidation_service|.
« no previous file with comments | « no previous file | chrome/browser/chromeos/policy/device_cloud_policy_invalidator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698